Bug 346346 - Clear button clears all plug-ins instead of selected one
Summary: Clear button clears all plug-ins instead of selected one
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2011-05-18 17:26 EDT by Krzysztof Kazmierczyk CLA
Modified: 2011-09-01 11:41 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kazmierczyk CLA 2011-05-18 17:26:59 EDT
Build Identifier: 02M7

When you click "Clear" button in Plug-in registry there are deleted all plug-ins. As a user I would expect deleting only the plug-in which is selected.

I am using FF 4.0

Reproducible: Always

Steps to Reproduce:
1. Go to plug-in registry
2. Select one plug-in
3. Click "clear" button - all the plug-ins are removed instead of selected.
Comment 1 Boris Bokowski CLA 2011-05-19 11:25:46 EDT
We should change the UI to an easier to understand presentation. I would suggest a more table-oriented approach similar to how Firefox displays the list of installed add-ons.

The rows of that table could look be something like this:

<icon><div><font bold+large>plugin name</font><br>
                        One sentence describing the plugin. <a href="javascript:expand row in-line with more information such as contributed services, and a link to a page with more information e.g. a wiki page">Details</a>
            </div><input type="button" value="Remove"></input>

Instead of a "clear all" button we should do a "refresh all", either as a button on the page, or as a side-effect of opening the page (similar to how the Eclipse about dialog starts verifying signed plugins when you open the dialog).
Comment 2 Susan McCourt CLA 2011-05-19 11:32:28 EDT
see also bug 339491.  didn't mark duplicate since there are specific ideas in here, too.  I'm going to give this page a couple hours of love for M8 and will see how far I get.
Comment 3 Susan McCourt CLA 2011-06-01 19:51:55 EDT
marking fixed, as I fixed the original problem.
There is now a "Uninstall Selected" link in the toolbar that will uninstall the selected plugins.  The refresh and clear icons are gone.

I didn't move to the table representation in the interest of time, I'd have to restructure this page which now relies on most of the behavior being implemented as a specialized tree widget.
Comment 4 Susan McCourt CLA 2011-06-01 20:00:41 EDT
(In reply to comment #1)
> We should change the UI to an easier to understand presentation. I would
> suggest a more table-oriented approach similar to how Firefox displays the list
> of installed add-ons.
> 
> The rows of that table could look be something like this:
> 
> <icon><div><font bold+large>plugin name</font><br>
>                         One sentence describing the plugin. <a
> href="javascript:expand row in-line with more information such as contributed
> services, and a link to a page with more information e.g. a wiki
> page">Details</a>
>             </div><input type="button" value="Remove"></input>

Moved this idea to bug 348033 for the future.

> 
> Instead of a "clear all" button we should do a "refresh all", either as a
> button on the page, or as a side-effect of opening the page (similar to how the
> Eclipse about dialog starts verifying signed plugins when you open the dialog).

The old clear code was simply deleting the tree and repopulating it, relying on the plug-in registry traversal to update the info.  Since the tree is recreated on page reload, it seemed to me that the refresh button added no value.  I removed it since the user can simply reload the page.

That said, I'm not sure if simply repopulating the tree will actually reread the plugin rather than use the cache.  I can say that reload acts exactly as the old refresh did.

Note also that I removed two levels from the tree
PluginRegistry
   Plugins
     plugin1
     plugin2

So now when the page opens you see
plugin1
plugin2
etc.