Bug 345986 - [releng] Builds are now 25Meg lighter
Summary: [releng] Builds are now 25Meg lighter
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 critical (vote)
Target Milestone: 4.1 RC3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2011-05-16 13:22 EDT by Paul Webster CLA
Modified: 2011-05-27 17:02 EDT (History)
4 users (show)

See Also:


Attachments
log file (6.69 KB, text/x-log)
2011-05-16 14:49 EDT, Andrew Niefer CLA
no flags Details
patch (9.94 KB, patch)
2011-05-16 16:07 EDT, Andrew Niefer CLA
no flags Details | Diff
updated patch (10.01 KB, patch)
2011-05-18 13:06 EDT, Andrew Niefer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-05-16 13:22:54 EDT
Our 4.1 SDK builds have dropped in size between I20110511-2200 and I20110512-2200.  ex:

182732224  eclipse-SDK-I20110511-2200-linux-gtk-x86_64.tar.gz
153611492  eclipse-SDK-I20110512-2200-linux-gtk-x86_64.tar.gz

for a total of about 27 Meg.  A brief scan of the 2 plugins directories wasn't able to shed light on what has changed.

PW
Comment 1 John Arthorne CLA 2011-05-16 13:35:42 EDT
Isn't a smaller size better? ;)


The ISV javadoc is missing...
Comment 2 Andrew Niefer CLA 2011-05-16 14:49:34 EDT
Created attachment 195779 [details]
log file

Attached log file shows the errors, the doc build is failing because it is trying to access files from other plugins which don't exist in the build because we are reconsuming binary versions of those plugins instead of building them again.
Comment 3 Andrew Niefer CLA 2011-05-16 15:05:09 EDT
Can something be done to platform.doc.isv/buildDoc.xml to copy most of the required content from a binary org.eclipse.platform.doc.isv_3.7.0.* and then generate javadoc for only the plugins that are being compiled in 4.1?
Comment 4 Andrew Niefer CLA 2011-05-16 16:07:00 EDT
Created attachment 195787 [details]
patch

Patch copies content from the 3.x binary doc.isv.  Requires testing.
Comment 5 Andrew Niefer CLA 2011-05-18 13:06:59 EDT
Created attachment 196008 [details]
updated patch
Comment 6 Andrew Niefer CLA 2011-05-18 13:41:08 EDT
I have released this change to the R4_HEAD stream and a test build is in progress.

However, an open problem remains for the version of the doc.isv bundle.

Since we are now taking content from the 3.7 version of the bundle, the tag on the 4.1 version in cvs is no longer sufficient as a qualifier if the 3.7 content has changed more recently.

Here, we probably need to use which ever qualifier between 3.7 vs 4.1 is most recent.
Comment 7 John Arthorne CLA 2011-05-19 10:00:58 EDT
(In reply to comment #6)
> Since we are now taking content from the 3.7 version of the bundle, the tag on
> the 4.1 version in cvs is no longer sufficient as a qualifier if the 3.7
> content has changed more recently.

This will cause a comparator failure, but I don't know if we're even running the comparator in the 4.1 build. Longer term we will need another solution since the current setup does not allow the 4.1 doc to publish any new API javadoc.
Comment 8 John Arthorne CLA 2011-05-27 17:02:50 EDT
Andrew fixed this.