Bug 345410 - [historyView] "Find" should offer option to search in all fields
Summary: [historyView] "Find" should offer option to search in all fields
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.12   Edit
Hardware: PC Linux-GTK
: P3 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2011-05-11 08:31 EDT by James Blackburn CLA
Modified: 2013-10-01 16:35 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2011-05-11 08:31:24 EDT 
Eclipse EGit (Incubation)	0.12.0.201103251413	org.eclipse.egit.feature.group
  Eclipse JGit (Incubation)	0.12.0.201103250414	org.eclipse.jgit.feature.group

The new Find feature in the history view seems very neat. While it allows to search for SHA's it doesn't allow searching for branch and tag names.

Some other nice to haves:
 - It should also have an option to search for all of Committer;Id;Author;Comments.
 - Filter the history view based on what's been typed in the 'Find' (rather than just highlighting in bold)
Comment 1 Markus Keller CLA 2011-11-14 09:23:34 EST 
Bug 324737 already asks for Find in Branch/Tag. This bug could be kept for the other enhancement requests (find in all fields, filter instead of highlight).
Comment 2 Robin Stocker CLA 2013-05-26 16:23:59 EDT 
There's an open change about finding in all fields here:

https://git.eclipse.org/r/#/c/12218/

The open question is, should there be a new option "All" or should the dropdown be changed from only allowing one selection to multi selection?
Comment 3 Markus Keller CLA 2013-05-27 09:01:15 EDT 
Drop-downs with many CHECK options are very inconvenient. We already made that mistake in the Next/Previous Annotation buttons in the toolbar for text-based editors, and it's a very frustrating experience if you need a dozen clicks and mouse drags just to invert the selection. Please don't repeat that mistake.

IMO, an "All" option is all we need here. For more elaborate searches, there's the Git Search dialog.
Comment 4 Stefan Lay CLA 2013-10-01 03:43:55 EDT 
Fixed with 88b5c09d0c7fe468a99f211b6e4ff1dd08ce0ddd