Bug 345003 - [preferences] Project-specific formatter profile changes lost after import/modify/rename
Summary: [preferences] Project-specific formatter profile changes lost after import/mo...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 RC1   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 324987
  Show dependency tree
 
Reported: 2011-05-06 13:12 EDT by Markus Keller CLA
Modified: 2011-05-16 06:23 EDT (History)
1 user (show)

See Also:
daniel_megert: review+

Attachments
Fix (913 bytes, patch)
2011-05-06 13:30 EDT, Markus Keller CLA 		no flags Details | Diff
Fix 2 (912 bytes, patch)
2011-05-09 05:28 EDT, Markus Keller CLA 		daniel_megert: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-05-06 13:12:26 EDT 
3.6.2 and HEAD

- import org.eclipse.jdt.junit from CVS
- edit project-specific code formatter properties
- edit the profile
- change an option
- change the name of the profile to "A"
- click OK, OK
=> change is lost, i.e. does not show up in org.eclipse.jdt.core.prefs

Works fine when trying a second time without changing the profile name.
Comment 1 Markus Keller CLA 2011-05-06 13:30:36 EDT 
Created attachment 194963 [details]
Fix
Comment 2 Markus Keller CLA 2011-05-06 13:36:28 EDT 
This is blocking progress on bug 324987.
Comment 3 Dani Megert CLA 2011-05-09 04:32:26 EDT 
Why do you set 'fManager' manager into the profile? I would expect that the manager given in the arguments is used.
Comment 4 Markus Keller CLA 2011-05-09 05:28:28 EDT 
Created attachment 195051 [details]
Fix 2

It's the same manager anyway, but I agree that using the argument is cleaner.
Comment 5 Dani Megert CLA 2011-05-09 05:41:00 EDT 
Comment on attachment 195051 [details]
Fix 2

+1 for RC1.
Comment 6 Markus Keller CLA 2011-05-09 06:27:16 EDT 
Fixed in HEAD.
Comment 7 Dani Megert CLA 2011-05-16 06:18:22 EDT 
Starting verification...
Comment 8 Dani Megert CLA 2011-05-16 06:23:44 EDT 
Verified in I20110512-2000.