Bug 344963 - Git commit buttons confusing
Summary: Git commit buttons confusing
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 0.2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2011-05-06 09:43 EDT by John Arthorne CLA
Modified: 2011-09-01 11:42 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-05-06 09:43:59 EDT 
The buttons for "Commit" and "Amend" aren't very intuitive. I find I have to read the tooltip all the time to make sure I'm doing the right thing. Also, "amend" is a potentially dangerous thing to do, and it is currently too easy to click it by mistake.

I suggest changing the buttons into text hyperlinks instead. For amend, another option is to make it a checkbox under the commit button so it is a little harder to click it by mistake.
Comment 1 Boris Bokowski CLA 2011-05-06 09:53:43 EDT 
+1 for changing it to a link (or a regular button with the label "Commit"). Also +1 for using a checkbox for the --amend option.

Another thing that has bothered me is that the commit comment is not cleared after the commit is performed.
Comment 2 libing wang CLA 2011-05-19 11:33:35 EDT 
fixed with 5304418a84eac7e9e39b966fcab42c40e7de77c7