Community
Participate
Working Groups
0.2 M7 Unit tests in /js-tests/textMateStyler/test.html are failing during the build in some browsers.
Firefox 4: FAILURE][test TextMateStyler create TextMateStyler][TypeError: style is null] ([object HTMLDivElement]) @http://localhost:8080/editor/js/editor.js:3238 () @http://localhost:8080/editor/js/editor.js:2557 ([object Object]) @http://localhost:8080/editor/js/editor.js:3773 Editor([object Object]) @http://localhost:8080/editor/js/editor.js:267 createEditor() @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:26 () @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:39 _run("",[object Object]) @http://localhost:8080/file/C/static/js/test.js:67 () @http://localhost:8080/file/C/static/js/test.js:190 _handleRequest("request[http://localhost:8080/file/C/static/js-tests/textMateStyler/test.html]",[object Object],(void 0)) @http://localhost:8080/file/C/static/js/plugin.js:76 ([object Object]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:788 _ec([object MessageEvent]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:1114 [FAILURE][test TextMateStyler style one line][TypeError: style is null] ([object HTMLDivElement]) @http://localhost:8080/editor/js/editor.js:3238 () @http://localhost:8080/editor/js/editor.js:2557 ([object Object]) @http://localhost:8080/editor/js/editor.js:3773 Editor([object Object]) @http://localhost:8080/editor/js/editor.js:267 createEditor() @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:26 () @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:39 _run("",[object Object]) @http://localhost:8080/file/C/static/js/test.js:67 () @http://localhost:8080/file/C/static/js/test.js:190 _handleRequest("request[http://localhost:8080/file/C/static/js-tests/textMateStyler/test.html]",[object Object],(void 0)) @http://localhost:8080/file/C/static/js/plugin.js:76 ([object Object]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:788 _ec([object MessageEvent]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:1114 [FAILURE][test TextMateStyler style multiple lines][TypeError: style is null] ([object HTMLDivElement]) @http://localhost:8080/editor/js/editor.js:3238 () @http://localhost:8080/editor/js/editor.js:2557 ([object Object]) @http://localhost:8080/editor/js/editor.js:3773 Editor([object Object]) @http://localhost:8080/editor/js/editor.js:267 createEditor() @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:26 () @http://localhost:8080/file/C/static/js-tests/textMateStyler/testcase.js:39 _run("",[object Object]) @http://localhost:8080/file/C/static/js/test.js:67 () @http://localhost:8080/file/C/static/js/test.js:190 _handleRequest("request[http://localhost:8080/file/C/static/js-tests/textMateStyler/test.html]",[object Object],(void 0)) @http://localhost:8080/file/C/static/js/plugin.js:76 ([object Object]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:788 _ec([object MessageEvent]) @http://localhost:8080/openajax/release/all/OpenAjaxManagedHub-all.js:1114
Internet Explorer 9: LOG: [FAILURE][test TextMateStyler style one line][TypeError: Unable to get value of the property 'lineIndex': object is null or undefined] LOG: [FAILURE][test TextMateStyler style multiple lines][TypeError: Unable to get value of the property 'lineIndex': object is null or undefined]
Firefox 3.6 also fails with similar errors as FF4
From my debugging in FF4 what I saw was that a call to getComputedStyle that looked ok was not working as expected. My bet is that this problem is specific to how we're running the tests and is occurring because we're running the test before the DOMContentLoaded event has fired. We need to track this and fix it for M8 but I don't think this is a blocker for M7.
These tests have now been failing for nearly two weeks. If you believe this is a problem in the tests can you please disable the test until the problem is sorted out? It's hard for people to have confidence taking our builds if they are always failing.
(In reply to comment #5) They are disabled now.
(In reply to comment #4) > From my debugging in FF4 what I saw was that a call to getComputedStyle that > looked ok was not working as expected. My bet is that this problem is specific > to how we're running the tests and is occurring because we're running the test > before the DOMContentLoaded event has fired. The problem seems to be that because the tests are run in a plugin, the editor gets created inside an iframe with "display:none". This causes getComputedStyle calls inside the editor to return undefined. I noticed that if you change pluginregistry.js to use display:"block" on the IframeContainer instead of "none", the tests pass. Although IE throws different errors, the cause is the same.
This problem is very serious to editor component. We can't port the editor unit tests to the orion test framework because of this bug. Simon, any ideas how to fix this problem ? Could you use display:block plus position:fixed;top=-1000px instead of display:none ? this way the iframe would still be invisible but the CSS part would work. (note that it still not ideal for ui test not to be able to see the component being tested but better than the current situation)
I added a 'MockTextView' test class that mimics the TextView API but does not touch the DOM. The tests now use this instead, so they will work during the build. I plan on using this mock class to test other stylers (CodeMirror) as well. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6aaecc01c54af1d2810066ee1f8177984b6b6b9b Added the tests to the jsTestSuite, marking fixed...
That's a great idea. I think we really still need to figure out a better way to handle tests that require the browser to be shown however this is fine approach and I bet other portions of Orion could re-use this.
