Bug 344327 - [Client][git] Git log : error happens when clicking on a commit in git log page based on a file.
Summary: [Client][git] Git log : error happens when clicking on a commit in git log pa...
Status: RESOLVED WORKSFORME
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks: 344330
  Show dependency tree
 
Reported: 2011-04-29 14:01 EDT by libing wang CLA
Modified: 2011-10-31 11:53 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description libing wang CLA 2011-04-29 14:01:38 EDT
In navigator page , go to git log page from a file .
Clicking on a commit opens Orion editor.
The editor is opened properly to show the file content on that commit.
but there are two things that look strange.
1.The title shows fileName?parts=body
2.The bread crumb is not rendered and the error message from console is :
http://localhost:8080/git/commit/2d21b4128fdf4e8d9e639d61c21732c8d49ec894/file/C/file3.txt?parts=body&parts=meta
Error loading file metadata: missing ) in parenthetical

In general , coding.js is trying to GET fileURI?parts=meta to build up the bread crumb. Not sure if ?parts=body&parts=meta will work in this case.

I had a similar issue in compare editor when comparing two commits :
1.The fileURI I get from the diffURI contains ?parts=body. So in order to show the proper file name I had to remove the ?parts=body programatically.
2.Even if I used fileURI?parts=meta to build up the bread crumb , the meta data is not returned.(Please note that I am not even using ?parts=body&parts=meta)
Comment 1 Tomasz Zarna CLA 2011-05-02 13:51:01 EDT
(In reply to comment #0)
> 2.Even if I used fileURI?parts=meta to build up the bread crumb , the meta data
> is not returned.(Please note that I am not even using ?parts=body&parts=meta)

This sounds like a server issue to me. What kind of response do you get?
Comment 2 Szymon Brandys CLA 2011-05-12 06:23:20 EDT
It's a problem with the editor. It seems it does not work well with resources other than files. I think we need a Silenio's comment on it.
Comment 3 Simon Kaegi CLA 2011-08-03 12:40:24 EDT
Is this still a problem - moving to m2 to ensure we take a look.
Comment 4 Szymon Brandys CLA 2011-08-23 10:21:45 EDT
Moving to Editor, see my comment 2.
Comment 5 Silenio Quarti CLA 2011-10-31 11:53:41 EDT
I was not able to reproduce this problem.