Bug 34373 - Class file view doesn't show actual modifiers for member types
Summary: Class file view doesn't show actual modifiers for member types
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-10 12:26 EST by Olivier Thomann CLA
Modified: 2007-03-20 07:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2003-03-10 12:26:06 EST 
Using RC2, the modifier for 
org.eclipse.jdt.internal.corext.codemanipulation.ImportsStructure$PackageEntry.c
lass is not private static as it should if the classfile reader used to display 
the disassembled source is not created using 
IClassFileReader.CLASSFILE_ATTRIBUTES.
The flag used in private void updateCodeView(StyledText styledText, IClassFile 
classFile) should be:
	int flags= IClassFileReader.FIELD_INFOS | IClassFileReader.METHOD_INFOS 
| IClassFileReader.SUPER_INTERFACES | IClassFileReader.CLASSFILE_ATTRIBUTES;

instead of:
	int flags= IClassFileReader.FIELD_INFOS | IClassFileReader.METHOD_INFOS 
| IClassFileReader.SUPER_INTERFACES;
Comment 1 Erich Gamma CLA 2003-03-12 14:44:58 EST 
moving to JDT Text
Comment 2 Dani Megert CLA 2006-07-11 08:04:00 EDT 
Tried as suggested and even used IClassFileReader.ALL but still 'static' doesn't appear.
Comment 3 Olivier Thomann CLA 2007-02-13 14:44:26 EST 
Released for 3.3M6.
The class mentioned in comment 0 doesn't exist anymore, but any private static member class would be good enough for testing.
Added regression test org.eclipse.jdt.core.tests.compiler.regression.ClassFileReaderTest_1_4#test077
Comment 4 David Audel CLA 2007-03-20 07:39:58 EDT 
Verified for 3.3 M6 using build I20070320-0010