Bug 341885 - [EditorReference] Pinned editor image overlay is not displayed
Summary: [EditorReference] Pinned editor image overlay is not displayed
Status: ASSIGNED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 06:36 EDT by Kaloyan Radev CLA
Modified: 2011-04-05 09:03 EDT (History)
1 user (show)

See Also:

Attachments
proposed patch based on diffs from RAP 1.3.2 (3.14 KB, patch)
2011-04-05 06:38 EDT, Kaloyan Radev CLA 		no flags Details | Diff
Clean patch (1.19 KB, patch)
2011-04-05 09:01 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Radev CLA 2011-04-05 06:36:31 EDT 
Build Identifier: RAP 1.3.2, RAP 1.4.M6

Pinned editor image overlay is not displayed and the comment in the source code states that OverlayImage is (still) not available, which is perfectly correct. Anyway the org.eclipse.jface.viewers.DecorationOverlayIcon could do the the same job.

Reproducible: Always

Steps to Reproduce:
1. Allow editor reusage with 

    IPreferenceStore prefStore = WorkbenchPlugin.getDefault().getPreferenceStore();
    prefStore.setValue(IPreferenceConstants.REUSE_EDITORS, 1);
    prefStore.setValue(IPreferenceConstants.REUSE_EDITORS_BOOLEAN, true);

2. Pin manually an editor.
3. The editor part image is not changed.
Comment 1 Kaloyan Radev CLA 2011-04-05 06:38:46 EDT 
Created attachment 192538 [details]
proposed patch based on diffs from RAP 1.3.2
Comment 2 Ivan Furnadjiev CLA 2011-04-05 09:01:52 EDT 
Created attachment 192552 [details]
Clean patch

This is the same patch created with Eclipse against CVS HEAD.