Bug 341790 - "there are build errors" window might not show, when errors are present
Summary: "there are build errors" window might not show, when errors are present
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 10:40 EDT by Tomas Martinec CLA
Modified: 2020-09-04 15:17 EDT (History)
3 users (show)

See Also:

Attachments
Fix (831 bytes, patch)
2011-04-04 10:40 EDT, Tomas Martinec CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Martinec CLA 2011-04-04 10:40:23 EDT 
Build Identifier: I20110127-2034

From reading the code I would guess, that method existsProblems of AbstractCLaunchDelegate2 might not work as expected. Because of it the user would not be warned during launching, that he has some build errors in the project. I did not try to produce that, so I am not absolutely sure about it.

Reproducible: Didn't try
Comment 1 Tomas Martinec CLA 2011-04-04 10:40:48 EDT 
Created attachment 192463 [details]
Fix
Comment 2 James Blackburn CLA 2011-04-04 10:48:08 EDT 
A better fix would be:

   return project.findMaxProblemSeverity(ICModelMarker.C_MODEL_PROBLEM_MARKER, true, IResource.DEPTH_INFINITE) >= IMarker.SEVERITY_ERROR;