Bug 34169 - Add JUnit TestSuite blocks
Summary: Add JUnit TestSuite blocks
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 critical (vote)
Target Milestone: 2.1 RC3   Edit
Assignee: Erich Gamma CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 34208 34243 34356 34438 34587 34772 34830 34833 34908 34957 35058 35062 35203 35269 35278 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-03-07 19:50 EST by Ihor Strutynskyj CLA
Modified: 2003-04-10 03:34 EDT (History)
20 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ihor Strutynskyj CLA 2003-03-07 19:50:19 EST
In RC2 I was able to add a new JUnit test suite using the wizard. After 2 or 3 
calls to wizard it stopped working. The "Next" button trigers some activity 
(mouse pointer changes) but does not advance to the next screen. The same 
workspace works fine with RC1 after this problem with RC2.
Comment 1 Ihor Strutynskyj CLA 2003-03-07 19:54:16 EST
I think it's it should be P1.
Comment 2 Ihor Strutynskyj CLA 2003-03-10 18:40:46 EST
Here are the log entries for this problem:

!ENTRY org.eclipse.ui.workbench 4 2 Mar 10, 2003 15:27:47.581
!MESSAGE Problems occurred when invoking code from plug-
in: "org.eclipse.ui.workbench".
!STACK 0
java.lang.ClassCastException
	at org.eclipse.ui.internal.dialogs.NewWizardNewPage$2.createWizard
(NewWizardNewPage.java:287)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode$2.run
(WorkbenchWizardNode.java:82)
	at org.eclipse.core.internal.runtime.InternalPlatform.run
(InternalPlatform.java:867)
	at org.eclipse.core.runtime.Platform.run(Platform.java:413)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode$1.run
(WorkbenchWizardNode.java:79)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:65)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode.getWizard
(WorkbenchWizardNode.java:77)
	at org.eclipse.jface.wizard.WizardSelectionPage.getNextPage
(WizardSelectionPage.java:90)
	at org.eclipse.jface.wizard.WizardDialog.nextPressed
(WizardDialog.java:671)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed
(WizardDialog.java:310)
	at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:417)
	at org.eclipse.swt.widgets.TypedListener.handleEvent
(TypedListener.java:87)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:836)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1777)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1485)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:577)
	at org.eclipse.jface.window.Window.open(Window.java:557)
	at org.eclipse.ui.actions.NewWizardAction.run(NewWizardAction.java:136)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:842)
	at org.eclipse.ui.internal.WWinKeyBindingService.pressed
(WWinKeyBindingService.java:214)
	at org.eclipse.ui.internal.WWinKeyBindingService$5.widgetSelected
(WWinKeyBindingService.java:328)
	at org.eclipse.ui.internal.AcceleratorMenu$2.handleEvent
(AcceleratorMenu.java:55)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:836)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1777)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1485)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1400)
	at org.eclipse.ui.internal.Workbench.run(Workbench.java:1383)
	at org.eclipse.core.internal.boot.InternalBootLoader.run
(InternalBootLoader.java:845)
	at org.eclipse.core.boot.BootLoader.run(BootLoader.java:461)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:247)
	at org.eclipse.core.launcher.Main.run(Main.java:703)
	at org.eclipse.core.launcher.Main.main(Main.java:539)
!ENTRY org.eclipse.ui 4 4 Mar 10, 2003 15:27:47.591
!MESSAGE Unhandled exception caught in event loop.
!ENTRY org.eclipse.ui 4 0 Mar 10, 2003 15:27:47.601
!MESSAGE 
!STACK 0
java.lang.IllegalArgumentException: 
	at org.eclipse.core.internal.runtime.Assert.isLegal(Assert.java:56)
	at org.eclipse.core.internal.runtime.Assert.isLegal(Assert.java:41)
	at org.eclipse.core.runtime.Status.setPlugin(Status.java:156)
	at org.eclipse.core.runtime.Status.<init>(Status.java:64)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode$2.handleException
(WorkbenchWizardNode.java:93)
	at org.eclipse.core.internal.runtime.InternalPlatform.handleException
(InternalPlatform.java:448)
	at org.eclipse.core.internal.runtime.InternalPlatform.run
(InternalPlatform.java:869)
	at org.eclipse.core.runtime.Platform.run(Platform.java:413)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode$1.run
(WorkbenchWizardNode.java:79)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:65)
	at org.eclipse.ui.internal.dialogs.WorkbenchWizardNode.getWizard
(WorkbenchWizardNode.java:77)
	at org.eclipse.jface.wizard.WizardSelectionPage.getNextPage
(WizardSelectionPage.java:90)
	at org.eclipse.jface.wizard.WizardDialog.nextPressed
(WizardDialog.java:671)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed
(WizardDialog.java:310)
	at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:417)
	at org.eclipse.swt.widgets.TypedListener.handleEvent
(TypedListener.java:87)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:836)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1777)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1485)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:577)
	at org.eclipse.jface.window.Window.open(Window.java:557)
	at org.eclipse.ui.actions.NewWizardAction.run(NewWizardAction.java:136)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:842)
	at org.eclipse.ui.internal.WWinKeyBindingService.pressed
(WWinKeyBindingService.java:214)
	at org.eclipse.ui.internal.WWinKeyBindingService$5.widgetSelected
(WWinKeyBindingService.java:328)
	at org.eclipse.ui.internal.AcceleratorMenu$2.handleEvent
(AcceleratorMenu.java:55)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:77)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:836)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:1777)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:1485)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1400)
	at org.eclipse.ui.internal.Workbench.run(Workbench.java:1383)
	at org.eclipse.core.internal.boot.InternalBootLoader.run
(InternalBootLoader.java:845)
	at org.eclipse.core.boot.BootLoader.run(BootLoader.java:461)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.eclipse.core.launcher.Main.basicRun(Main.java:247)
	at org.eclipse.core.launcher.Main.run(Main.java:703)
	at org.eclipse.core.launcher.Main.main(Main.java:539)
Comment 3 Erich Gamma CLA 2003-03-11 04:30:28 EST
This is a regression that got introduce when removing some non API conforming 
subclassing. The JUnitWizardPage class should implement INewWizard.

Adjusted the priority and severity: there is no loss of data and there is a 
workaround (create the test suite manually in code). 

Index: src/org/eclipse/jdt/internal/junit/wizards/JUnitWizard.java
===================================================================
RCS 
file: /home/eclipse/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/wiz
ards/JUnitWizard.java,v
retrieving revision 1.3
diff -u -r1.3 JUnitWizard.java
--- src/org/eclipse/jdt/internal/junit/wizards/JUnitWizard.java	5 Mar 2003 
17:21:34 -0000	1.3
+++ src/org/eclipse/jdt/internal/junit/wizards/JUnitWizard.java	11 Mar 2003 
09:29:43 -0000
@@ -17,6 +17,7 @@
 import org.eclipse.jface.wizard.Wizard;
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Shell;
+import org.eclipse.ui.INewWizard;
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPage;
 import org.eclipse.ui.PartInitException;
@@ -26,7 +27,7 @@
 /**
  * The wizard base class for JUnit creation wizards.
  */
-public abstract class JUnitWizard extends Wizard {
+public abstract class JUnitWizard extends Wizard implements INewWizard {
 
 	private IWorkbench fWorkbench;
 	protected static String DIALOG_SETTINGS_KEY= "JUnitWizards"; //$NON-NLS-
1$
Comment 4 Erich Gamma CLA 2003-03-11 04:38:44 EST
*** Bug 34438 has been marked as a duplicate of this bug. ***
Comment 5 Erich Gamma CLA 2003-03-11 04:58:20 EST
*** Bug 34208 has been marked as a duplicate of this bug. ***
Comment 6 Erich Gamma CLA 2003-03-11 05:28:20 EST
*** Bug 34243 has been marked as a duplicate of this bug. ***
Comment 7 Erich Gamma CLA 2003-03-11 05:40:58 EST
*** Bug 34356 has been marked as a duplicate of this bug. ***
Comment 8 Roel De Meester CLA 2003-03-12 06:13:56 EST
I guess my bug is adressing the samen problem.


When i Right-click on a TestSuite i can select "recreate TestSuite"


Doing this results in a window "Recreate Test Suite" 


where there are NO "Test Classes to be included" (list is empty), stating 


"No entries are available",


the Select All, and Deselect All buttons are not responinf to mouse clicks. The 
only thing i can do is. "Cancel".


Comment 9 Erich Gamma CLA 2003-03-12 08:47:03 EST
*** Bug 34587 has been marked as a duplicate of this bug. ***
Comment 10 Erich Gamma CLA 2003-03-12 09:09:54 EST
*** Bug 34772 has been marked as a duplicate of this bug. ***
Comment 11 Erich Gamma CLA 2003-03-12 13:42:01 EST
*** Bug 34833 has been marked as a duplicate of this bug. ***
Comment 12 Erich Gamma CLA 2003-03-12 14:24:10 EST
*** Bug 34830 has been marked as a duplicate of this bug. ***
Comment 13 Erich Gamma CLA 2003-03-13 09:54:24 EST
*** Bug 34908 has been marked as a duplicate of this bug. ***
Comment 14 Erich Gamma CLA 2003-03-13 10:30:50 EST
fix released reviewed by Martin
Comment 15 Erich Gamma CLA 2003-03-13 17:11:14 EST
*** Bug 34957 has been marked as a duplicate of this bug. ***
Comment 16 Richard Clark CLA 2003-03-14 16:40:19 EST
*** Bug 35062 has been marked as a duplicate of this bug. ***
Comment 17 Adam Kiezun CLA 2003-03-17 05:27:53 EST
*** Bug 35058 has been marked as a duplicate of this bug. ***
Comment 18 Adam Kiezun CLA 2003-03-18 08:15:45 EST
*** Bug 35203 has been marked as a duplicate of this bug. ***
Comment 19 Erich Gamma CLA 2003-03-19 03:41:16 EST
*** Bug 35269 has been marked as a duplicate of this bug. ***
Comment 20 Adam Kiezun CLA 2003-03-19 06:31:18 EST
*** Bug 35278 has been marked as a duplicate of this bug. ***
Comment 21 Jean-Michel Garnier CLA 2003-03-19 07:05:20 EST
The Junit wizard works if youreplace the org.eclipse.jdt.junit_2.1.0 plugin by the 
org.eclipse.jdt.junit_2.0.1
Comment 22 Dani Megert CLA 2003-03-20 12:34:31 EST
Verified against I20030319
Comment 23 Larry Edelstein CLA 2003-04-09 19:39:56 EDT
I get something similar with the 2.1 release whenever I hit "next" in the JUnit 
wizard, with either "TestCase" or "TestSuite" selected; error log entries are 
written, and nothing else happens (I am still in the wizard).  

If I double-click on either, I get slightly different behavior - an alert, 
indicating that "An error has occured.  See error log for more details.", and 
somewhat different error log entries.
Comment 24 Erich Gamma CLA 2003-04-10 03:34:47 EDT
please open a new bug with steps to reproduce and attach the log file entries.