Bug 341522 - [client] confusing disappearance of push button menu in hovering action column
Summary: [client] confusing disappearance of push button menu in hovering action column
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2011-03-31 12:42 EDT by Susan McCourt CLA
Modified: 2011-12-08 01:34 EST (History)
1 user (show)

See Also:


Attachments
screenshot (28.93 KB, image/png)
2011-03-31 12:42 EDT, Susan McCourt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-03-31 12:42:01 EDT
Created attachment 192301 [details]
screenshot

The hovering actions disappear when you mouse out of a navigator row.
This is okay except for the case where you are selecting something from an action's push button menu that is dropped down past the row.  In that case we want the actions column to stay visible.
Comment 1 Susan McCourt CLA 2011-04-27 11:26:17 EDT
I think it makes sense to address this alongside bug 338888, where we will introduce some kind of lifecycle for menus for inserting commands on menu open.
Comment 2 Susan McCourt CLA 2011-09-28 12:53:08 EDT
this bug is particularly bad on git clones page, where there is a lot of space between the branch name and the actions column.  It's hard to be sure you fetched, etc. from the right repo.
Comment 3 Susan McCourt CLA 2011-10-25 11:33:41 EDT
we need to revisit the hover approach in general (for touch, etc.) and once we know what we wish to do, fix problems like these (if they still exist)
Comment 4 Susan McCourt CLA 2011-12-08 01:34:18 EST
fixed in 0381955c9eef7286e3804cb07b13be2d3fb5ee1b

This has been driving me nuts forever.
The idea that we could have "menu knows when it is open" styling behavior was not going to work as long as we were hiding the parent span in the navigator.  This also was an accessibily problem because you could never tab to the actions.

I removed the nav code that hide/shows the containing parent.
I added command service code to allow active/inactive classes in addition to the classes the command framework uses.  I also added some dijit styling to keep the hover background when the menu is selected (focused).

So now the menu button stays "hover gray" while it's active.  The only time that it's hard to tell is if you have a bunch of rows selected with the checkbox.  Then the gray background is the same as selection background.  But even then, the text itself is darker when the menu is active.