Bug 341498 - Pie Charts are not accessible
Summary: Pie Charts are not accessible
Status: RESOLVED FIXED
Alias: None
Product: MAT
Classification: Tools
Component: GUI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Krum Tsvetkov CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 300655
  Show dependency tree
 
Reported: 2011-03-31 10:58 EDT by Toby Corbin CLA
Modified: 2011-04-08 08:44 EDT (History)
2 users (show)

See Also:


Attachments
patch solves the accessibility problem (9.93 KB, patch)
2011-03-31 11:02 EDT, Toby Corbin CLA
krum.tsvetkov: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toby Corbin CLA 2011-03-31 10:58:20 EDT
Build Identifier: Version: Helios Service Release 1

The Pie Chart in the overview pane is not readable by the JAWS screen reader and additionally does not provide keyboard navigation around the chart.  This prevents the pie chart being accessible

Reproducible: Always

Steps to Reproduce:
1. Install JAWS screen reader
2. Load a dump into MAP
3. On the overview pane, attempt to select the pie chart using the keyboard
4. On the overview pane, have the JAWS screen reader try and read the slices in the pie chart
Comment 1 Toby Corbin CLA 2011-03-31 11:02:31 EDT
Created attachment 192286 [details]
patch solves the accessibility problem

The fix I've attached allows keyboard navigation into the pie chart and then by adding a keyboard trigger, I can walk round the slices in the the chart and update the label field with the current slice. 

To enable the screen reader to read the value, I set the accessible name of the canvas to be the currently selected slice.

I've also added a paintlistener to the canvas so that it is obvious to the user when they have tabbed into the pie chart canvas.

NOTE.  this does make changes to one of the files included in the patch supplied in bug 341482 but that change is not included in this patch
Comment 2 Krum Tsvetkov CLA 2011-04-04 07:53:25 EDT
Thanks for the patch! I would like to go and try the several accessibility related patches that were proposed recently. 
>> NOTE. this does make changes to one of the files included in the patch supplied in bug 341482 but that change is not included in this patch
Just to clarify and prevent that I am doing the wrong thing - in which order should I apply the patches? First the one from bug 341482 or vice versa?
Comment 3 Toby Corbin CLA 2011-04-04 08:27:48 EDT
(In reply to comment #2)
> Thanks for the patch! I would like to go and try the several accessibility
> related patches that were proposed recently. 
> >> NOTE. this does make changes to one of the files included in the patch supplied in bug 341482 but that change is not included in this patch
> Just to clarify and prevent that I am doing the wrong thing - in which order
> should I apply the patches? First the one from bug 341482 or vice versa?

The two patches can be applied independantly of each other and affect different things so the order is not important.
Comment 4 Pete Robbins CLA 2011-04-04 08:49:05 EDT
I think one patch will need to be reworked after the first one is applied. I'm not sure how clever svn merge is. I can easily update a patch if necessary against the latest level once one or other is applied.
Comment 5 Krum Tsvetkov CLA 2011-04-08 08:22:23 EDT
I reviewed the patch and tested it. 
Navigation through the chart worked good and I would like to submit the changes.
I still have the problem (same as in bug 340196) that windows narrator sometimes reads text of the slice, but sometimes tells me things about an invisible progress bar. I have no JAWS to test with it, and also have no real experience with the windows narrator. Therefore, for the moment I would ignore the narrator problem and accept the patch. 

To fulfill the process requirements, please could you confirm for the patch:
1.that you wrote 100% of the code
2.that you are authorized to contribute it
3.that is is submitted under the EPL.

You could also update the copyright header - set last modification to 2011 and add IBM as a contributor. But this minor change I can also do before submitting the patch.

Thanks a lot for your effort!
Comment 6 Toby Corbin CLA 2011-04-08 08:33:39 EDT
(In reply to comment #5)
> I reviewed the patch and tested it. 
> Navigation through the chart worked good and I would like to submit the
> changes.
> I still have the problem (same as in bug 340196) that windows narrator
> sometimes reads text of the slice, but sometimes tells me things about an
> invisible progress bar. I have no JAWS to test with it, and also have no real
> experience with the windows narrator. Therefore, for the moment I would ignore
> the narrator problem and accept the patch. 
> 
> To fulfill the process requirements, please could you confirm for the patch:
> 1.that you wrote 100% of the code
> 2.that you are authorized to contribute it
> 3.that is is submitted under the EPL.
> 
> You could also update the copyright header - set last modification to 2011 and
> add IBM as a contributor. But this minor change I can also do before submitting
> the patch.
> 
> Thanks a lot for your effort!

I can confirm that I wrote 100% of the code, I am authorised to contribute and it is submitted under the EPL.

Rather than me submit and patch, please could you modify the copyright header.

Many thanks

Toby
Comment 7 Krum Tsvetkov CLA 2011-04-08 08:42:25 EDT
Comment on attachment 192286 [details]
patch solves the accessibility problem

I submitted the changes in the SVN repository (change 1096)
Comment 8 Krum Tsvetkov CLA 2011-04-08 08:44:21 EDT
I adjusted the copyright header and set the iplog flag for your patch.
I think I can close the message now. Thanks!