Bug 340925 - [repoView] Use counter styler for Remotes and Tags nodes
Summary: [repoView] Use counter styler for Remotes and Tags nodes
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 20:04 EDT by Kevin Sawicki CLA
Modified: 2011-03-25 13:55 EDT (History)
1 user (show)

See Also:


Attachments
Example counter styling (26.10 KB, image/png)
2011-03-24 20:17 EDT, Kevin Sawicki CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Sawicki CLA 2011-03-24 20:04:25 EDT
Use counter styler in RepositoriesViewLabelProvider to style Tags and Reomtes
nodes in Git Repositories view with number of items underneath.
Comment 1 Kevin Sawicki CLA 2011-03-24 20:17:46 EDT
Created attachment 191880 [details]
Example counter styling
Comment 2 Kevin Sawicki CLA 2011-03-24 20:18:07 EDT
Fix pushed to: http://egit.eclipse.org/r/2921
Comment 3 Mathias Kinzler CLA 2011-03-25 04:25:04 EDT
(In reply to comment #0)
> Use counter styler in RepositoriesViewLabelProvider to style Tags and Reomtes
> nodes in Git Repositories view with number of items underneath.

I'd like to challenge the use case: what is the added value for the user of the view to see the number of tags and remotes?

They already have the "hasChildren" indicator next to the respective node, so they can already see whether there are tags or remotes and we should be careful not to clutter the tree with pointless information.

(same remarks were added to the Gerrit change).
Comment 4 Kevin Sawicki CLA 2011-03-25 13:55:57 EDT
The counter styler can be used as a form of progressive disclosure to allow users to understand the amount of information that will be displayed upon expansion.

The hasChildren indicator isn't always displayed on all platforms all the time, it is sometimes done only on hover.

It can also be helpful for operations done outside of Eclipse.  For example, a user dropping to the command line to delete a tag will now get feedback on the deletion whether or not they have the Tags node expanded because the counter will decrement.