Bug 340623 - Support configurable colors in EGit History view
Summary: Support configurable colors in EGit History view
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2011-03-22 00:56 EDT by Kevin Sawicki CLA
Modified: 2015-09-10 17:02 EDT (History)
2 users (show)

See Also:

Attachments
Screenshot of links in revision/commit view pane of history view (76.27 KB, image/png)
2013-11-18 00:05 EST, Chad Bamford CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Sawicki CLA 2011-03-22 00:56:21 EDT 
Make colors used for lines and dots in EGit History view configurable through:

Preferences -> General -> Appearances -> Colors and Fonts -> Git folder
Comment 1 Chad Bamford CLA 2013-11-15 23:56:32 EST 
Not just for "lines and dots', but all textual items too :)! Those links are awfully hard to read against a dark background
Comment 2 Robin Stocker CLA 2013-11-16 07:52:31 EST 
Could you attach a screenshot?
Comment 3 Chad Bamford CLA 2013-11-18 00:05:33 EST 
Created attachment 237519 [details]
Screenshot of links in revision/commit view pane of history view

The colors (I'm particularly refering to) are coded in org.eclipse.egit.ui.internal.history.CommitMessageViewer.java (lines 77-93). 

[Interesting - from the Platform Plug-in Development Guide (Kepler): What's New?: SWT Changes : A new constant (SWT_COLOR_LINK_FOREGROUND) has been added that returns the native color of hyperlinks on all platforms.

Still trying to create build environment for EGit on Kepler (looks like p2 needs some work).
Comment 4 Robin Stocker CLA 2013-11-20 17:20:15 EST 
(In reply to Chad Bamford from comment #3)
> Created attachment 237519 [details]
> Screenshot of links in revision/commit view pane of history view

We're currently considering changing how the information is displayed there to be more like in the commit viewer. Do the links and the diff there look better for you? Right click on a commit in the history and select Open in Commit Viewer.

> [Interesting - from the Platform Plug-in Development Guide (Kepler): What's
> New?: SWT Changes : A new constant (SWT_COLOR_LINK_FOREGROUND) has been
> added that returns the native color of hyperlinks on all platforms.

Interesting. Unfortunately, we can't yet use this as our current policy is to support the current version of Eclipse and the one before.

> Still trying to create build environment for EGit on Kepler (looks like p2
> needs some work).

Are you refering to bug 409073? Note that it's not necessary to install all tools from there, using a target platform as described here should be enough for the dependencies:

https://wiki.eclipse.org/EGit/Contributor_Guide#Option_1:_Use_a_Target_Platform

If you have any problems, don't hesitate to write to the mailing list (we're friendly :)), we want contributing to be as straightforward as possible.
Comment 5 Eclipse Genie CLA 2015-09-09 01:29:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/55509
Comment 6 Eclipse Genie CLA 2015-09-10 17:02:41 EDT 
Gerrit change https://git.eclipse.org/r/55509 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=d731994757fe6d4ffa076441124a22072de41898