Bug 340615 - Navigator actions activate onHover is bad for the Xoom, iPad, etc.
Summary: Navigator actions activate onHover is bad for the Xoom, iPad, etc.
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 M1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: 365361
  Show dependency tree
 
Reported: 2011-03-21 18:21 EDT by Simon Kaegi CLA
Modified: 2011-12-08 01:29 EST (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-03-21 18:21:09 EDT
I was using the Xoom last night with orion.eclipse.org and for the most part it worked well except getting the actions to appear was tricky. We probably should avoid using onhover.
Comment 1 Susan McCourt CLA 2011-03-21 19:13:47 EDT
I have code in the command framework right now that checks
this._deviceSupportsHover
and conditionally creates the hover effect.  But I have no idea if in practice we can figure out if hover is supported by the device.  I'd hate to rule it out for all cases.
Comment 2 Susan McCourt CLA 2011-12-01 15:47:03 EST
This is an accessibility issue as well.
There is currently no way to use the keyboard to get to the hovering image commands/more menu.
Comment 3 Carolyn MacLeod CLA 2011-12-02 00:05:55 EST
Can you use onfocus instead? (or in addition to onhover)?
And then, I guess, onblur to hide stuff when focus goes elsewhere?
Comment 4 Susan McCourt CLA 2011-12-08 01:27:43 EST
Fixed in 9fe5864c6c98dfee17f1c1ef91a6932c4b229cef.

Note this fix is navigator/explorer specific, so it changes the behavior of the navigator, git clones, git log, etc.  (And for git log, the styling is not exactly right, the actions aren't fading enough).

Other places that hover commands in custom code won't be fixed yet.

I'm closing this bug because it concerns nav actions but we will need to open new bugs for places that are inconsistent.

For the most part, I think this plays better, once you get used to it, for example I really like seeing "Git Status" as a visible link on the clones page rather than hover around to see if I can do it.  On the other hand, it really emphasizes where our commands are kind of in random order/unorganized by icon/link.  For example if you expand several levels deep in the clones page it's a mess.

However we really need to lose the hover appear/disappear so I've released this code.
Comment 5 Susan McCourt CLA 2011-12-08 01:29:23 EST
one more thing...we also have an accessibility improvement here now.
I verified that you can get to the more menu by keyboard now.  Also, the "hover" opacity darkening occurs on keyboard focus and hover.

Also verified that you can now single click actions column actions on the ipad.