Bug 340145 - [quick fix] Problems with nested captures in quick fixes and extract ... refactorings
Summary: [quick fix] Problems with nested captures in quick fixes and extract ... refa...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on: 150657
Blocks:
  Show dependency tree
 
Reported: 2011-03-16 08:20 EDT by Markus Keller CLA
Modified: 2023-05-06 19:18 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-03-16 08:20:58 EDT
HEAD, same problem in 3.6.2 and 3.5.2

The fix for bug 103044 in ImportRewrite#addImport(*) doesn't solve the examples from bug 103044 in a satisfying way, since it completely removes the type argument and replaces it with a '?'. Furthermore, the quick fixes now propose types that are different from what actually happens in code (the types in the proposals are also wrong, since they would lead to compile errors).

The problem is in TypeChangeCorrectionProposal, which just uses ASTResolving.getRelaxingTypes(*). It should also do something like Bindings#normalizeForDeclarationUse(*). Unfortunately, the latter also doesn't handle nested captures correctly. Since we cannot create new bindings efficiently, we probably need a new addImport method that does everything right.
Comment 1 Eclipse Genie CLA 2019-04-12 13:04:33 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Eclipse Genie CLA 2021-04-05 03:17:16 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Eclipse Genie CLA 2023-05-06 19:18:58 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.