Bug 339573 - Splitting the shared area with a part doesn't remove stale placeholders
Summary: Splitting the shared area with a part doesn't remove stale placeholders
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 M6   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-10 14:11 EST by Eric Moffatt CLA
Modified: 2011-03-10 14:17 EST (History)
0 users

See Also:

Attachments
Patch to remove *all* stale placeholders whenever anything gets added to the shared area (3.81 KB, patch)
2011-03-10 14:16 EST, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-03-10 14:11:44 EST 
The current code only looks for the addition of an MPlaceholder in the shared area as the hint to remove locals. When you split the area the element that gets added is the new MPartSashContainer...
Comment 1 Eric Moffatt CLA 2011-03-10 14:16:14 EST 
Created attachment 190901 [details]
Patch to remove *all* stale placeholders whenever anything gets added to the shared area


While this appears to be computationally expensive the overall cost is quite low because the number of elements involved isn't very large.

For example a presentation with 10 perspectives open each with 20 views only amounts to 200 tests...
Comment 2 Eric Moffatt CLA 2011-03-10 14:17:11 EST 
Committed in >20110310. Applied the patch.
Comment 3 Eric Moffatt CLA 2011-03-10 14:17:34 EST 
Setting milestone, will verify tomorrow...