Community
Participate
Working Groups
Created attachment 190793 [details] screenshot if the path names are long in the compare view, then they wrap to the next line. However, they get truncated. I stretched the page larger and all the extra space is going to the editor. Seems we need to allow those headers to wrap and get bigger if needed.
Created attachment 205927 [details] screenshot of 0.3 here's the current state. Another thing that's odd is that the header on the left is left justified, and the header on the right is right justified. So we are seeing completely different information about each one. Suggestions: - the url fluff is not important (we don't need the "gitapi/commit" or "parts=body") - the commit id and filename are most important - the middle path stuff is less important, perhaps an ellipsis eabd1ff2d3c69f7d6ec4e5607f734bd71619ec0e...textView.js Perhaps a button that can be pushed to expand the header to as many lines as needed to show everything if the user needs to see it. so
i'd like to see us make a serious polish pass during 0.4 for these kinds of things, so marking 0.4
(In reply to comment #1) > eabd1ff2d3c69f7d6ec4e5607f734bd71619ec0e...textView.js IMO a better approach would be to render it like this ".../textView.js @ eabd1ff2d3". The ellipsis could be expanded to the full path in the tooltip on hover. The shorten SHA should be enough for the user, but again it could be expanded on hover, showing the full SHA + a commit message(?). Moreover, the SHA could be a link to the Commit details page from bug 360472.
(In reply to comment #1) > Created attachment 205927 [details] > screenshot of 0.3 > > here's the current state. Another thing that's odd is that the header on the > left is left justified, and the header on the right is right justified. So we > are seeing completely different information about each one. Suggestions: I believe it is due to the right adjustment of the compare command span. Should be easy to fix. > - the url fluff is not important (we don't need the "gitapi/commit" or > "parts=body") > - the commit id and filename are most important > - the middle path stuff is less important, perhaps an ellipsis > > eabd1ff2d3c69f7d6ec4e5607f734bd71619ec0e...textView.js I think Tomasz's idea in comment 3 is good. I may need more information from server. > > Perhaps a button that can be pushed to expand the header to as many lines as > needed to show everything if the user needs to see it. This may be hard. Because we always have to align all the div height on left-right side. Maybe we can just show full name on hover as Tomasz suggested.
(In reply to comment #3) > (In reply to comment #1) > > eabd1ff2d3c69f7d6ec4e5607f734bd71619ec0e...textView.js > > IMO a better approach would be to render it like this ".../textView.js @ > eabd1ff2d3". The ellipsis could be expanded to the full path in the tooltip on > hover. The shorten SHA should be enough for the user, but again it could be > expanded on hover, showing the full SHA + a commit message(?). Moreover, the > SHA could be a link to the Commit details page from bug 360472. Tomasz, I think we can take this approach. Currently I am just using the file URI for both to render the title, which was silly, I agree. I think here the file name itself is not very important because the doc title already shows the readable name. The "what VS what"(e.g. "working tree VS index", "commit x VS commit y") is more usable. Besides the two file URIs, what else can I use from server side. One option I was thinking is to get file meta data but it seemed not working on git commit URI.
> I think here the file name itself is not very important because the doc title > already shows the readable name. The "what VS what"(e.g. "working tree VS > index", "commit x VS commit y") is more usable. Agree, though I don't see any file name in the browser tab, just "Compare." We could definitely put the file name in the title as well as the breadcrumb/location area in the header underneath the "Compare" page title. Agree that we can truncate the SHA, and I like linking to proposed commit page (let's use the same truncation utility method for showing commits) (In reply to comment #4) > This may be hard. Because we always have to align all the div height on > left-right side. > Maybe we can just show full name on hover as Tomasz suggested. If we shorten up the names being shown, maybe the wrapping part won't be so bad...
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
