Bug 338642 - Arguments constructed from the option pane in the tool.xml incorrectly split into tokens
Summary: Arguments constructed from the option pane in the tool.xml incorrectly split ...
Status: ASSIGNED
Alias: None
Product: PTP
Classification: Tools
Component: ETFw (show other bugs)
Version: 6.0.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Wyatt Spear CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2011-03-02 05:27 EST by Tan Wen Jun CLA
Modified: 2014-06-09 16:43 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tan Wen Jun CLA 2011-03-02 05:27:42 EST 
In org.eclipse.ptp.etfw.toolopts.ToolApp, the function "public List<String> getArguments(ILaunchConfiguration configuration)" incorrectly assumes that the value returned from allInput[i].getArgument(configuration) contains only 1 argument. Therefore the split only works for 1 argument.

Incorrect splitting of arguments can cause the external tool to fail as the arguments passed to the tool is different.
Comment 1 Greg Watson CLA 2011-09-14 10:03:15 EDT 
Adding Wyatt to CC as he is looking at ETFw currently.
Comment 2 Wyatt Spear CLA 2012-09-24 13:31:57 EDT 
Can I get a specific example of where/how this is causing a tool to fail?  The final argument string should be reassembled without loss of information even if it wasn't fully split.  This code needs to be revisited anyway because it isn't safe to assume that arguments are split on a 'space/dash'.
Comment 3 Greg Watson CLA 2014-06-09 16:43:24 EDT 
This bug can't be addressed without further information.