Bug 338373 - [navigation] FUP of bug 171019: adjust selection detector for @inheritDoc javadoc tag
Summary: [navigation] FUP of bug 171019: adjust selection detector for @inheritDoc jav...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 04:01 EST by Ayushman Jain CLA
Modified: 2011-03-08 12:16 EST (History)
4 users (show)

See Also:

Attachments
Fix (4.57 KB, patch)
2011-02-28 12:22 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ayushman Jain CLA 2011-02-28 04:01:53 EST 
Due to the fix for bug 171019, CTRL+CLICK on @inheritDoc tag behaves the same way as it does on a method name. This needs to be suitably changed.
Comment 1 Markus Keller CLA 2011-02-28 09:34:23 EST 
What do you want to have changed? I think it's fine as it is (works like an @see reference to the same method).
Comment 2 Ayushman Jain CLA 2011-02-28 10:54:39 EST 
(In reply to comment #1)
> What do you want to have changed? I think it's fine as it is (works like an
> @see reference to the same method).

I would expect the @inheritDoc tag to navigate to the method from where the javadoc is actually coming. CTRL+clicking on it, and chosing show declaration or implementation is a bit counter-intuitive, because if the user really wanted to do so, he'd have done the CTRL+click on the method name and not the javadoc tag. The choice "open return type" also seems a bit misplaced here.

I don't have a very strong reason to change this, but I feel navigation through inheritDoc tag should be precise, leading only to the method who's javadoc has been inherited.
Comment 3 Markus Keller CLA 2011-02-28 12:22:40 EST 
Created attachment 189969 [details]
Fix

OK, I've disabled the other hyperlinks and the hovers.
Comment 4 Markus Keller CLA 2011-02-28 12:24:10 EST 
Fixed in HEAD.
Comment 5 Raksha Vasisht CLA 2011-03-07 00:51:04 EST 
Verified for 3.7 M6 with N20110305-2000.
Comment 6 Rajesh CLA 2011-03-08 12:16:22 EST 
Verified on Mac with I20110307-2110