Description Jesse 2011-02-22 11:49:33 EST

*My mistake if these have already been reported*

1. Some of the import statements at the top of the .xtext file are duplicates, and are missing the required "#//____" portions. 

eg. 

generated: 
import "platform:/resource/org.eclipse.e4.ui.model.workbench/model/UIElements.ecore" as commands

fix:
import "platform:/resource/org.eclipse.e4.ui.model.workbench/model/UIElements.ecore#//commands" as commands

2.

The type UIElements was not auto-generated in the grammar, but the some of the "children" attributes for types (specified by the auto-generated grammar) require UIElements. However, we should probably use types that are a little further down the tree. ie. Menu_Impl's children for the auto-generated grammar says it requires UIElements, but should probably be using MenuElements.

eg. 

generated:
('children' '{' children+=UIElement ( "," children+=UIElement)* '}' )?

possible fix:
('children' '{' children+=MenuElement ( children+=MenuElement)* '}')? //MenuElement

*though this won't actually work until you've included MenuElement in the grammar... and takes me to the next point*

3. Entire hierarchy of UIElements doesn't get generated. Some stuff needed to be added/changed in order to get most of the UIElements hierarchy.

Again... I noticed the same stuff in 1.01, so I apologize if this has already been reported. 

Thanks!

- Jesse