Community
Participate
Working Groups
Created attachment 189355 [details] changes requrired for jsf features +++ This bug was initially created as a clone of Bug #336519 +++ There is a new Eclipse license (EUA) that includes a new line about EDL. And, rather than do a "mass file/property update" we should move to the new "PDE build" technique to reference the license file, which is then included at build-time, so future updates are easier. This issue is discussed in Kim's blog post; http://relengofthenerds.blogspot.com/2011/01/implementing-shared-licenses-with-37m5.html I'll try a few test features ... say, xml features, just to make sure it works as expected then provide patches/instructions for a mass update.
Thanks for the patch.
Build just broke, with msg pasted below. Offhand, based on the "conflicts with property" part of the message, my guess this is same issue as in bug 337655. Got'ta be all or nothing. Or ... I could easily have missed something on one of the changes I made in the patch. = = = = [build-wtp-jst-sdk] BUILD FAILED [build-wtp-jst-sdk] /shared/webtools/projectBuilders/wtp-R3.3.0-I/webtools.releng/releng.wtpbuilder/scripts/build/runbuild.xml:143: The following error occurred while executing this line: [build-wtp-jst-sdk] /opt/public/webtools/basebuilders/v20110216/org.eclipse.releng.basebuilder/plugins/org.eclipse.pde.build_3.6.100.v20110121-1730/scripts/build.xml:37: The following error occurred while exec uting this line: [build-wtp-jst-sdk] /opt/public/webtools/basebuilders/v20110216/org.eclipse.releng.basebuilder/plugins/org.eclipse.pde.build_3.6.100.v20110121-1730/scripts/build.xml:118: The following error occurred while exe cuting this line: [build-wtp-jst-sdk] /shared/webtools/projectBuilders/wtp-R3.3.0-I/webtools.releng/releng.wtpbuilder/components/jst-sdk/customTargets.xml:92: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projectBuilders/wtp-R3.3.0-I/webtools.releng/releng.wtpbuilder/components/jst-sdk/allElements.xml:35: The following error occurred while executing this line: [build-wtp-jst-sdk] /opt/public/webtools/basebuilders/v20110216/org.eclipse.releng.basebuilder/plugins/org.eclipse.pde.build_3.6.100.v20110121-1730/scripts/genericTargets.xml:186: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/assemble.org.eclipse.jst.sdk.all.xml:25: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/assemble.org.eclipse.jst.sdk.all.xml:15: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projectBuilders/wtp-R3.3.0-I/webtools.releng/releng.wtpbuilder/components/jst-sdk/allElements.xml:65: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/assemble.org.eclipse.jst.sdk.p2.xml:30: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/assemble.org.eclipse.jst.sdk.p2.xml:376: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/assemble.org.eclipse.jst.sdk.p2.xml:16: The following error occurred while executing this line: [build-wtp-jst-sdk] /shared/webtools/projects/wtp-R3.3.0-I/workdir/features/org.eclipse.jst.webpageeditor.feature/build.xml:81: Property licenseURL in /shared/webtools/projects/wtp-R3.3.0-I/workdir/features/or g.eclipse.jst.webpageeditor.feature/../org.eclipse.license/feature.properties conflicts with property in /shared/webtools/projects/wtp-R3.3.0-I/workdir/features/org.eclipse.jst.webpageeditor.feature/feature.te mp.folder/features/org.eclipse.jst.webpageeditor.feature_2.3.3.v201103022146-4629oB5865F6I3142/feature.properties [build-wtp-jst-sdk] [build-wtp-jst-sdk] Total time: 21 minutes 36 seconds [build-wtp-jst-sdk] An error has occurred. See the log file [build-wtp-jst-sdk] /opt/public/webtools/projects/wtp-R3.3.0-I/workdir/I-3.3.0-20110303183854/buildworkspaces/workspace-runbuild-jst-sdk/.metadata/.log. [build-wtp-jst-sdk] Java Result: 13
Created attachment 190317 [details] patch for three features Not sure if it was errors in previous patches, or what, but from what I can see in my workspace, looks like three features need corrections
The first patch had errors in the 3 features and I fixed them based on the changes in the other features, but looks like it was not complete. I have applied the latest patch and released the changes.
thank you. looks good.
New Gerrit change created: https://git.eclipse.org/r/114268
New Gerrit change created: https://git.eclipse.org/r/114267
Gerrit change https://git.eclipse.org/r/114268 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=f73c69358545428a0dbc0efa372c21d3c5bff6fe
Gerrit change https://git.eclipse.org/r/114267 was merged to [master]. Commit: http://git.eclipse.org/c/jsf/webtools.jsf.git/commit/?id=5e224289eda023bfac0428fd11cc96116b7331bc
