Bug 33640 - Editor colors do not take effect on Apply
Summary: Editor colors do not take effect on Apply
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0.1   Edit
Assignee: Cherie Wong CLA
QA Contact:
URL:
Whiteboard:
Keywords: readme
Depends on:
Blocks:
 
Reported: 2003-03-03 00:20 EST by Ron Baldwin CLA
Modified: 2004-08-27 11:28 EDT (History)
1 user (show)

See Also:

Attachments
Syntax coloring in PDE Editors (16.87 KB, patch)
2004-07-07 16:10 EDT, Cherie Wong CLA 		no flags Details | Diff
Syntax coloring in PDE Editors - Resources Leak Patch (20.18 KB, patch)
2004-07-09 10:52 EDT, Cherie Wong CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Baldwin CLA 2003-03-03 00:20:56 EST 
Open the plugin.xml editor and select the Source tab.  Changes made to colors in
Preferences->Plug-in Development->Editors does not take effect on Apply, you
must close and reopen the editor.
Comment 1 Wassim Melhem CLA 2003-06-18 03:32:20 EDT 
Fixed.
Comment 2 Wassim Melhem CLA 2004-06-22 22:28:53 EDT 
Problem reappeared in the new editors.  Reopening and tagging as README for 
3.0.
Comment 3 Cherie Wong CLA 2004-07-07 16:10:21 EDT 
Created attachment 13024 [details]
Syntax coloring in PDE Editors

Wassim, please verify the patch.  I tested to make sure we were disposing of
our color managers to prevent massive flooding. :)
Comment 4 Cherie Wong CLA 2004-07-09 10:52:46 EDT 
Created attachment 13109 [details]
Syntax coloring in PDE Editors - Resources Leak Patch

An adjustment was made such that all old colors are disposed of when the new
colors are applied.  Although we were not leaking memory, this action is needed
to free OS resources.

Please verify this patch :)
Comment 5 Wassim Melhem CLA 2004-07-12 15:24:44 EDT 
Candidate for 3.0.1
Comment 6 Cherie Wong CLA 2004-07-12 15:29:45 EDT 
Fixed.  Released to head and 3.0.1 branch. :)
Comment 7 Cherie Wong CLA 2004-08-27 11:28:09 EDT 
Verified on M20040825.