Bug 335418 - [terminal] A "clear terminal" ANSI sequence paints incorrect background
Summary: [terminal] A "clear terminal" ANSI sequence paints incorrect background
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-26 00:47 EST by Martin Oberhuber CLA
Modified: 2020-09-04 15:12 EDT (History)
1 user (show)

See Also:


Attachments
Sample terminal log with escape sequences (120.11 KB, text/plain)
2011-01-26 00:47 EST, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2011-01-26 00:47:26 EST
Created attachment 187610 [details]
Sample terminal log with escape sequences

Build ID: TM I20110125 and all earlier versions

As per the ANSI spec:
   http://en.wikipedia.org/wiki/Ansi_terminal

an "ESC 2 J" sequence to clear the Terminal should paint the terminal with the current background color. But the Terminal uses the default background.

This can be observed by playing attached TXT file over a com0com virtual nullmodem connection into the Serial terminal : The background is expected to go all black (like in PuTTY or Hyperterm), but the TM Terminal goes all white in the end.
Comment 1 Martin Oberhuber CLA 2011-01-26 00:48:21 EST
The reason is that in TerminalTextData the various "cleanLine" methods all delete the entire backing storage. They should instead keep the backing storage for attributes, and fill it with the current background color.
Comment 2 Jonah Graham CLA 2020-05-01 10:08:36 EDT
The Terminal component of the Eclipse Ecosystem has a new home. The Terminal is now part of the Eclipse CDT project[1].

This change means a new Git repo[2], P2 site[3] and Bugzilla component. The terminal will continue to be delivered as part of the quarterly Simultaneous Release of Eclipse as well.

The marketplace entry[4] had not been updated in a few years. It will once again install the latest release of the terminal on the latest release of the whole IDE (currently 2020-03).

If this bug is no longer relevant, please feel free to comment or close the bug. If you can confirm if this issues still occurs in the latest release please do let me know in a comment.

[1] https://wiki.eclipse.org/CDT/User/NewIn911
[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git (in the terminal directory)
[3] current release is 9.11 - P2 site https://download.eclipse.org/tools/cdt/releases/9.11/
[4] https://marketplace.eclipse.org/content/tm-terminal

(This comment was added to all open terminal bugs along with changing the Product/component pair to CDT/terminal.)