Comment 1 Andrew Johnson 2011-01-25 13:10:07 EST

Created attachment 187550 [details]
Patch to existing MAT projects to enable RAP

Approved by CQ 4723

Comment 2 Andrew Johnson 2011-01-25 13:13:47 EST

Created attachment 187552 [details]
Additional plugin projects for MAT for web enablement using RAP

Approved by CQ 4723

Hi Andrew:

I've been able to complete full review as part of the triage stage.

A couple of small changes that should be made before the content is checked in:

1.  ActionFactoryFacadeImpl.java contains the following 
 "About", "(c) Copyright Eclipse contributors and others 2000, 2009.  All
rights reserved.")

Copyright should not be assigned to Eclipse contributors (please note this
information is not contained in the header but included quite a distance down
in the file)

2. ...

Otherwise, this CQ is approved!

Cheers,
Sharon

Comment 3 Andrew Johnson 2011-01-25 13:16:15 EST

Created attachment 187553 [details]
Modify eclipse help system for use in RAP environment

Approved by CQ 4723

Hi Andrew:

I've been able to complete full review as part of the triage stage.

A couple of small changes that should be made before the content is checked in:

1.  ...

2.  The patch contains the word 'hack', you may wish to adjust:-)

Otherwise, this CQ is approved!

Cheers,
Sharon

Comment 4 Andrew Johnson 2011-01-25 13:17:30 EST

Created attachment 187554 [details]
RAP compatibility, forwarding UI calls from MAT to RAP

Approved by CQ 4723

Comment 5 Eclipse Webmaster 2024-05-08 14:42:33 EDT

This issue has been migrated to https://github.com/eclipse-mat/org.eclipse.mat/issues/16.