Bug 335309 - [formatter] FUP of bug 332843: add regression test
Summary: [formatter] FUP of bug 332843: add regression test
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 08:39 EST by Ayushman Jain CLA
Modified: 2011-03-08 11:07 EST (History)
1 user (show)

See Also:

Attachments
Proposed fix (7.14 KB, patch)
2011-02-14 12:47 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ayushman Jain CLA 2011-01-25 08:39:47 EST 
The fix for bug 332843 can be tested with test project attached in bug 332843#comment11. We should capture this test somehow in the formatter tests.
Comment 1 Olivier Thomann CLA 2011-02-14 11:55:45 EST 
I tried to extract a test case using the attached project, but it doesn't fail anymore (I reverted the fix first).
Comment 2 Olivier Thomann CLA 2011-02-14 12:01:16 EST 
I reproduced using 3.7M4. Investigating.
Comment 3 Olivier Thomann CLA 2011-02-14 12:47:38 EST 
Created attachment 188926 [details]
Proposed fix

This test fails with 3.7M4 and passes with HEAD.
Comment 4 Olivier Thomann CLA 2011-02-14 12:48:00 EST 
Released for 3.7M6.
Comment 5 Stephan Herrmann CLA 2011-03-08 11:07:09 EST 
Verified for 3.7M6 by running test from HEAD in 3.7M4
(original SIOOBE is thrown as expected).