Bug 335283 - [Theming] Remove left-overs from property-based theming
Summary: [Theming] Remove left-overs from property-based theming
Status: ASSIGNED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 04:32 EST by Rüdiger Herrmann CLA
Modified: 2013-04-24 10:04 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2011-01-25 04:32:13 EST 
In Widget.theme.xml there is an "*" element alongside with a comment:
  Eliminate when property support is gone

As property-based theming isn't supported anymore (to my knowledge), can this element be removed?
Comment 1 Ralf Sternberg CLA 2011-01-25 05:27:26 EST 
Yes, we should eliminate these remains, but we can't get rid of the "*" element right away since there are still a couple of references to it in the AppearancesBase.js. Those need to be replaced by the real element names before.

We should also get rid of Control.theme.xml and Control.default.css.
Comment 2 Ivan Furnadjiev CLA 2012-05-23 07:13:08 EDT 
We recently had a problem with "*" CSS definitions in "business" and "fancy" themes. If an element is not defined in the theme (Table-RowOverlay in our case) it does not fallback to the "fallback" theme. Definitions from the asterisk selector are used instead, leading to weird appearance. Before we remove it, we have to ensure that it is not used in any appearance files and the corresponding CSS properties are added to every widget (font, background-color, background-image, color).