Bug 335093 - [compiler][null] minimal hook for future null annotation support
Summary: [compiler][null] minimal hook for future null annotation support
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-22 14:36 EST by Stephan Herrmann CLA
Modified: 2011-01-25 09:28 EST (History)
1 user (show)

See Also:
Olivier_Thomann: review+


Attachments
proposed implementation (6.51 KB, patch)
2011-01-22 14:44 EST, Stephan Herrmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-01-22 14:36:59 EST
As bug 186342 has been deferred past M5 I'm preparing a separate plugin that
will provide the same functionality for interested users to try out.

Using normal mechanisms (API and extension points) such separation is of
course not possible, but I have prepared an implementation that uses OT/J
for the integration into the JDT/Core.

Only one location is very difficult to adapt in the JDT/Core and only for
this location I'm asking permission to insert a minimal effectless hook.
This hook will actually be useful for a final implementation regarding
null annotations, too.
Comment 1 Stephan Herrmann CLA 2011-01-22 14:44:31 EST
Created attachment 187363 [details]
proposed implementation

This patch inserts the requested hook as an effectless function
into class Statement. This function is called from one location
within each of LocalDeclaration and Assignment (during analyseCode).

Also I changed one test helper in AbstractRegressionTest from package private
to protected in order to make it accessible for tests in yet another plugin.
Comment 2 Stephan Herrmann CLA 2011-01-22 14:49:18 EST
Olivier, is it OK to release this for M5?

This would indeed allow me to ship the mentioned extra plugin to work
with M5 once that is released.
Comment 3 Olivier Thomann CLA 2011-01-22 18:10:01 EST
+1. Give it a try. We can always revert if too controversial.
Comment 4 Stephan Herrmann CLA 2011-01-22 18:42:03 EST
Released for 3.7M5.
Comment 5 Olivier Thomann CLA 2011-01-25 09:28:22 EST
Verified for 3.7M5 using I20110124-1800 (code inspection)