Bug 334008 - FeatureExportOperation does not setup the container feature properly
Summary: FeatureExportOperation does not setup the container feature properly
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2011-01-11 12:45 EST by Jeff McAffer CLA
Modified: 2011-01-26 13:59 EST (History)
3 users (show)

See Also:

Attachments
patch to add unpack=false (1.06 KB, patch)
2011-01-11 12:45 EST, Jeff McAffer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2011-01-11 12:45:28 EST 
Created attachment 186533 [details]
patch to add unpack=false

in i0104 

When exporting a product PDE creates a container feature to capture all that needs to be built.  See FeatureExportOpertion.createFeature. In particular, this feature includes all the stuff in the product as well as the launcher bundle and fragment if requested.  When exporting without generating metadata the information in this feature is used to compute the shape of the launcher bundles.  The container feature is not correctly defining that shape.

It should be setting unpack=false for the launcher bundle.  A patch to that effect is attached.
Comment 1 Jeff McAffer CLA 2011-01-11 12:47:53 EST 
I should have said, the net effect of this is that the output product has an invalid entry in the bundles.info list.  The equinox.launcher location is missing .jar at the end.  As a result, simple configurator fails to install the launcher.  Since this is not actually a bundle the system still runs but you get some errors in the log and if you are running something that actually looks for the launcher bundle (eg. the pde build product) then errors ensue.
Comment 2 Jeff McAffer CLA 2011-01-11 14:03:10 EST 
This should likely be in PDE UI as the code is actually in the pde.core bundle. Moving...
Comment 3 Ankur Sharma CLA 2011-01-12 01:24:18 EST 
Thanks for the patch. We will try to test it out for M5 but can not commit.
Comment 4 Curtis Windatt CLA 2011-01-24 15:46:28 EST 
Now that I actually looked into this bug I see that it only changes the shape of the launcher bundle.

Fixed in HEAD.
Comment 5 Curtis Windatt CLA 2011-01-26 13:59:01 EST 
Verified that the fix is in I20110126-0800