Bug 333828 - XMLHeadTokenizer had different byte codes when using new JDT compiler
Summary: XMLHeadTokenizer had different byte codes when using new JDT compiler
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: wst.xml CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 333678
  Show dependency tree
 
Reported: 2011-01-10 00:43 EST by David Williams CLA
Modified: 2011-02-26 18:46 EST (History)
0 users

See Also:


Attachments
decompiler listing from 3.6 compiler (129.56 KB, text/plain)
2011-01-10 00:45 EST, David Williams CLA
no flags Details
decompiled output from current (3.7M4) compiler (129.63 KB, text/plain)
2011-01-10 00:45 EST, David Williams CLA
no flags Details
original source (44.82 KB, application/octet-stream)
2011-01-10 00:46 EST, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-01-10 00:43:59 EST
As far as I can see, this is not due to "unused variables" as are other cases related to bug 333678. It might be due to some other "fix" in the compiler? Or ... something? 

I'll attach "decompiled" versions as well as original source. If you do a "diff" you can see the difference is what was 

     848  iconst_1
     849  istore 8 [zzIsFinal]
     851  iconst_1
     852  istore 9 [zzNoLookAhead]
     854  aload_0 [this]
     855  bipush 7
     857  putfield org.eclipse.wst.xml.core.internal.contenttype.XMLHeadTokenizer.zzState : int [269]
     860  goto 6060
     863  iload_1 [zzInput]
     864  tableswitch default: 996

becomes


     848  iload_1 [zzInput]
     849  pop
     850  iconst_1
     851  istore 8 [zzIsFinal]
     853  iconst_1
     854  istore 9 [zzNoLookAhead]
     856  aload_0 [this]
     857  bipush 7
     859  putfield org.eclipse.wst.xml.core.internal.contenttype.XMLHeadTokenizer.zzState : int [269]
     862  goto 6060
     865  iload_1 [zzInput]
     866  tableswitch default: 996

I've no idea what the significance is ... but ... the fact is, we have different bytes bits with same version/qualifier. So ... technically we should re-tag. I think re-tag is sufficient, since this code is already different from maintenance, and the error report simply says current I-builds differ from our M4 (we used old compiler in M4).
Comment 1 David Williams CLA 2011-01-10 00:45:11 EST
Created attachment 186351 [details]
decompiler listing from 3.6 compiler
Comment 2 David Williams CLA 2011-01-10 00:45:37 EST
Created attachment 186352 [details]
decompiled output from current (3.7M4) compiler
Comment 3 David Williams CLA 2011-01-10 00:46:06 EST
Created attachment 186353 [details]
original source
Comment 4 David Williams CLA 2011-02-26 18:46:28 EST
This no longer shows up in unexpected comparator logs ... not sure if it was "fixed on purpose", or retagged for other reasons, but end result seems to be 'fixed'.