Bug 333827 - BindingColumnLayout has unused variables treated differently with new compiler
Summary: BindingColumnLayout has unused variables treated differently with new compiler
Status: RESOLVED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.3 M6   Edit
Assignee: David Williams CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 333678
  Show dependency tree
 
Reported: 2011-01-10 00:10 EST by David Williams CLA
Modified: 2011-02-26 19:05 EST (History)
0 users

See Also:

Attachments
patch to remove unused variables (1.85 KB, patch)
2011-01-10 00:10 EST, David Williams CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-01-10 00:10:09 EST 
Created attachment 186350 [details]
patch to remove unused variables

related to bug 333678 ... 

This class has unused variable treated differently with new JDT compiler. Now correctly detected as "unused" are removed from byte code. 

But, this make the bundles have different bits, but same version and qualifier. 

I'd suggest in this case the code actually be fixed ... pretty clearly is not needed? The attached patch remove the variable and increments the service field by +1. Note, should be +100 if change made in only HEAD. (And, currently no plans to change compiler in maintenance ... normally a bad idea ... but, we might want to since that stream may be long lived).
Comment 1 David Williams CLA 2011-01-10 00:16:50 EST 
I see now this class is already different in HEAD than maintenance, so no need to change 'service field' again, it already has been.
Comment 2 David Williams CLA 2011-02-26 19:05:28 EST 
applied and released patch to remove unused variables from source