Bug 333732 - fix in 3.7 compiler improves "unused variable" detection, so changes byte codes
Summary: fix in 3.7 compiler improves "unused variable" detection, so changes byte codes
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.command (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: David Williams CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 333678
  Show dependency tree
 
Reported: 2011-01-07 04:49 EST by David Williams CLA
Modified: 2011-02-26 01:27 EST (History)
0 users

See Also:

Attachments
patch for unused variables. (15.27 KB, patch)
2011-01-07 04:49 EST, David Williams CLA 		no flags Details | Diff
improved patch without erroneous "changed" lines (3.14 KB, patch)
2011-01-10 00:01 EST, David Williams CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-01-07 04:49:53 EST 
Created attachment 186253 [details]
patch for unused variables.

bug 333678 has more gory details, but the bottom line is that in the WTP 3.3 stream we really should change the version/qualifier of the org.eclipse.wst.command.env.ui bundle, since its bits have changed. Practically, it does not make any difference in the code running, but ... as a general principle, if the bits change the version/qualifier should change. 

Technically speaking, we could just leave everything the same, and our current build system will simply deliver the older 3.6 compiled version ... to technically there should not be two "differing" bundles out in the wild ... but, seems to me that's just asking for long term trouble. 

So, will attach a patch to increment the versioning, and also remove the unused variables from the source. 

Comments/review is welcome.
Comment 1 David Williams CLA 2011-01-07 04:52:39 EST 
Sorry, guess I "auto format" my code, so appears a lot of lines changed ... when only about 4 lines in java file changed. I'll can improve that, if needed, but this will give you the idea and you can comment if it is worth pursuing.
Comment 2 David Williams CLA 2011-01-10 00:01:34 EST 
Created attachment 186349 [details]
improved patch without erroneous "changed" lines
Comment 3 David Williams CLA 2011-02-26 01:27:15 EST 
applying patch for M6.