Bug 3331 - DCR: Code Formatter should offer cast without space (1GI74GZ)
Summary: DCR: Code Formatter should offer cast without space (1GI74GZ)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 enhancement (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 6301 29556 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:53 EDT by Dani Megert CLA
Modified: 2003-02-11 06:39 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2001-10-10 22:53:21 EDT 
We normally use the following code stye when casting:
		x= (MyClass)y;
	The code formatter reformats this to:
		x= (MyClass) y;


NOTES:
EG (8/20/2001 11:15:46 AM)
	the code formatter should provide additional options for white space insertion.
	moving to JCORE
Comment 1 Philipe Mulet CLA 2001-10-11 08:27:59 EDT 
Not critical. Defer for now
Comment 2 DJ Houghton CLA 2001-10-29 17:10:08 EST 
PRODUCT VERSION:
	0.128
Comment 3 Philipe Mulet CLA 2002-07-25 06:30:57 EDT 
Resurrecting formatter issues in 2.1 stream.
Comment 4 Philipe Mulet CLA 2002-07-25 06:32:45 EDT 
Clearing resolution
Comment 5 Olivier Thomann CLA 2002-11-05 16:30:51 EST 
*** Bug 6301 has been marked as a duplicate of this bug. ***
Comment 6 Olivier Thomann CLA 2003-01-15 13:22:54 EST 
We need to clear 2.1 bug reports that won't be addressed before 2.1. The new 
implementation is still in the works. Therefore we cannot include it for 2.1. 
Not enough testing and we need to polish the preferences. This will be address 
for 2.2 as stated in the JDT/Core plan.
Comment 7 Dani Megert CLA 2003-01-16 02:39:25 EST 
Why was a new identical (bug 29556) report opened and this one resolved as later?
Comment 8 Olivier Thomann CLA 2003-01-16 08:16:40 EST 
I will close the new PR as duplicate. I didn't see this one.
Comment 9 Olivier Thomann CLA 2003-01-16 08:17:07 EST 
*** Bug 29556 has been marked as a duplicate of this bug. ***
Comment 10 Olivier Thomann CLA 2003-01-16 08:17:43 EST 
You didn't tell me if the patch works as expected.
Comment 11 Dani Megert CLA 2003-01-16 08:45:04 EST 
You did not see this one? You just closed it 14 minutes before opening the new
one ;-)

>You didn't tell me if the patch works as expected.
You mentioned the patch but neither one of the PRs nor the e-mail contained a patch.
Comment 12 Olivier Thomann CLA 2003-01-16 08:48:12 EST 
The patch is avaible on the JDT/Core page with the patches for 2.1.
http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/jdt-core-
home/r2.1/main.html#updates

I closed all PRs related to the formatter in one command. I didn't close them 
one by one.
Comment 13 Olivier Thomann CLA 2003-01-17 09:23:19 EST 
Fixed and released in 2.1 stream.
Regression test added.
Comment 14 David Audel CLA 2003-02-11 06:39:42 EST 
Verified.