Community
Participate
Working Groups
This is a patch submission from group SachaMowha, composed of Joe Handzik, Marc Celani, Joe Gonzalez, and Jason Patel. We completed the Add Subroutine Parameter refactoring, and would like to contribute our refactoring to the Photran project. Please let us know if there is anything else you would like us to do! Thanks, Joe Handzik
Created attachment 185202 [details] Patch containing Add Subroutine Parameter refactoring.
Thanks for the contribution! There are a few minor changes I'd like you to make before I can accept this. Please resubmit the patch with the following changes: 1. The copyright headers for the following files need to be changed. Copyright should be ascribed to the four of you as individuals, not to UIUC, since this was not a work for hire. Similarly, the "initial API and implementation" line should have your names, not UIUC. - AddSubroutineParameterRefactoring - AddSubroutineParameterTestSuite - AddSubroutineParameterAction 2. Please add @author tags to the JavaDoc comment for the AddSubroutineParameterRefactoring class. 3. If you have time, please format the Java code similarly to the other refactoring classes. Mostly, this means putting opening braces on the next line and making sure there's a space between "if" or "while" and the opening parenthesis. (You should be able to use the Source > Format menu item to do this, but if you do, please scan over the code to make sure the formatter didn't do anything unseemly.) Obviously, I haven't had time to fully try your code yet, but these changes will be sufficient to start the IP review process.
Also, for the IP review, I will need *each* of you (Marc Celani, Joe Handzik, Joe Gonzalez, Jason Patel) to individually confirm (as a comment on this bug) that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files.
(In reply to comment #3) > Also, for the IP review, I will need *each* of you (Marc Celani, Joe Handzik, > Joe Gonzalez, Jason Patel) to individually confirm (as a comment on this bug) > that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, > > 2. you have the right to contribute the code to Eclipse, and > > 3. you have included the EPL license header in all source files. We did not use any code from elsewhere, or rely on the intellectual property rights of others. I have the right to contribute to the code, as Facebook does not in any way compete with Eclipse/Photran. Joe G, you may want to take a look at the language in your non-compete agreement with regard to this. Since this code is working on refactoring code for fortran development, I think you are okay - Visual Studio does not appear to offer any fortran services in and of itself. However, I suppose the argument could be made that by developing for eclipse in any way, you are competing with Visual Studio. Jeff, I'm sure you've had students before who work for Microsoft. Any opinion on this? Depending on the language of the non compete, you may only have to list your inventions (that was what Facebook would have required, if it were a competing service). As soon as we fix up the contributor names, and @author tags from your previous comment, this is ready. Marc Celani
Actually, we haven't run into this before. I e-mailed the IP team; I'll let you know what they say...
Created attachment 185246 [details] Revised version of Add Subroutine Parameter refactoring
1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files. 100% of the code in our refactoring is from either ourselves or from the Photran project itself, no content was taken from elsewhere, nor does it rely on the IP of others. I have the right to contribute code to Eclipse, I haven't been hired yet for a job after school, so I don't have any sort of contract that I need to refer to. I do work for the university, but I would assume that doesn't interfere with this project. We included the EPL license header in all of our source files. I have submitted a revised version of our refactoring, with all of the changes you mentioned below implemented. Joe Handzik
100% of the code in our refactoring is from either ourselves or from the Photran project itself, no content was taken from elsewhere, nor does it rely on the IP of others. I have the right to contribute code to Eclipse, I haven't been hired yet for a job after school, so I don't have any sort of contract that I need to refer to. I do work for the university, but I would assume that doesn't interfere with this project. We included the EPL license header in all of our source files
Joe G, before I can grant your group extra credit for CS427 (I need to get that to Ralph tomorrow), I need you to confirm, as a comment on this bug, that either (1) you cannot contribute this code due to your contract, or (2) you comfortable submitting this code, in which case I also need you to explicitly confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files.
These are committed to CVS HEAD for inclusion in Photran 7.0/Indigo (the June, 2011 release). Thanks again for the contribution! Please also make sure your names are all included and are spelled correctly on the Contributors page: http://www.eclipse.org/photran/contributors.php
