Comment 1 Chad Zamzow 2010-12-10 22:33:49 EST

Created attachment 185015 [details]
Patch for Make Save Explicit Refactoring, modifying core.vpg, core.vpg.tests, and ui.vpg

Comment 2 Jeffrey Overbey 2010-12-13 04:45:40 EST

Hi all,

Thanks for the contribution!  It looks good... there are just a few minor issues I'd like you to fix before we send this off for an IP review.  Please re-submit the patch with these changes:

1. In the copyright headers for MakeSaveExplicitRefactoring and MakeSaveExplicitTestSuite, please remove "UIUC - Initial API and implementation" and put your names there instead.  This will avoid any confusion during the IP review.

2. There is no need to override #configureRefactoring in your test suite since you only invoke the superclass implementation.

3. Please give the #currAST field private visibility.  Also, you can remove the "IFortranAST ast" parameter from #makeChangesTo since the AST is available to that method via the field.

4. Where possible, please replace the use of explicit iterators with the use of Java 5 for-each loops.  For example, 

    Iterator<ASTEntityDeclNode> declIterator = entityDeclList.iterator();
    while(declIterator.hasNext())
    {
        ASTEntityDeclNode variableDeclaration = declIterator.next();
        ...

can be replaced with


    for (ASTEntityDeclNode variableDeclaration : entityDeclList)
    {
        ...

Thanks a lot!

Comment 3 Jeffrey Overbey 2010-12-14 18:12:00 EST

Hi guys -- just to give you a heads up, I have to let Ralph know who will get extra credit for CS427 by Friday.  If you don't have time to make the changes I requested, I can still accept your patch as-is (the changes were very minor); just please let me know.

Either way, I will need the five of you (Stephen, Robert, Kevin, Jon, and Chad) to *each* add a comment to this bug confirming that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files.

Comment 4 Jon Woolwine 2010-12-14 18:28:04 EST

Hi Jeff,

We should have the changes up by tonight or tomorrow. We just had to work out who can do it becuase of finals. Here's my confirmation stuff:

1. I wrote 100% of the code that I contributed to without incorporating content
from elsewhere or relying on the IP of others.
2. I have the right to contribute the code to Eclipse.
3. All the source files we created have the EPL license header within them.

Thanks,
Jon Woolwine

Comment 5 Stephen Downs 2010-12-14 18:47:52 EST

1. I wrote 100% of the code that I contributed to without incorporating content
from elsewhere or relying on the IP of others.
2. I have the right to contribute the code to Eclipse.
3. All the source files we created have the EPL license header within them.

Stephen Downs

Comment 6 Chad Zamzow 2010-12-15 04:18:16 EST

Created attachment 185210 [details]
Make Save Explicit Refactoring, Version 2

Fixed version of the Make Save Explicit Refactoring, modifying core.vpg, core.vpg.tests, and ui.vpg

Comment 7 Chad Zamzow 2010-12-15 04:22:36 EST

Uploaded the new patch, which includes updated versions of MakeSaveExplicitRefactoring.java and MakeSaveExplicitTestSuite.java.  That should do it, I think.

1. I wrote 100% of the code that I contributed to without incorporating content
from elsewhere or relying on the IP of others.
2. I have the right to contribute the code to Eclipse.
3. All the source files we created have the EPL license header within them.

Chad Zamzow

Comment 8 Kevin 2010-12-15 04:37:43 EST

Hi Jeff,

We made all the changes, now we just need to resubmit them as a patch.

Here's my confirmation stuff:

1. I wrote 100% of the code that I contributed to without incorporating content
from elsewhere or relying on the IP of others.
2. I have the right to contribute the code to Eclipse.
3. All the source files we created have the EPL license header within them.

Thanks,
-Kevin Schilling

Comment 9 Robert Samblanet 2010-12-15 04:41:10 EST

1. I wrote 100% of the code that I contributed to without incorporating content
from elsewhere or relying on the IP of others.
2. I have the right to contribute the code to Eclipse.
3. All the source files we created have the EPL license header within them.

Thanks,
Rob Samblanet

Comment 10 Jeffrey Overbey 2010-12-15 10:58:47 EST

Thanks for the replies!

For the IP review, I will need to describe how much of the work was done by each person involved.  Generally, for CS427 projects, the work was more-or-less evenly distributed, so I will use the following breakdown unless you inform me otherwise:

Stephen Downs - 20%
Robert Samblanet - 20%
Kevin Schilling - 20%
Jon Woolwine - 20%
Chad Zamzow - 20%

I'll start the IP review process soon.  If the IP team has any questions, I'll post them here.

Comment 11 Jeffrey Overbey 2010-12-15 11:23:04 EST

CQ 4700 Submitted - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4700

Comment 12 Jeffrey Overbey 2011-01-18 15:08:07 EST

The CQ was approved.  Check in to CVS pending.

Comment 13 Jeffrey Overbey 2011-03-16 16:43:47 EDT

These are committed to CVS HEAD for inclusion in Photran 7.0/Indigo (the June, 2011 release).

Thanks again for the contribution!

Please also make sure your names are all included and are spelled correctly on the Contributors page: http://www.eclipse.org/photran/contributors.php