Community
Participate
Working Groups
Build Identifier: I20100527-1700 See apache bug: https://issues.apache.org/jira/browse/NET-288 This has been fixed in 2.2.0, when will the bundle be updated in orbit? Reproducible: Always Steps to Reproduce: 1. Try to connect to a server using FTP via an IPv6 address 2. 3.
Whow, that was fast ... commons net must have just been released! For TM/RSE I'm afraid IPv6 support is not relevant since I don't think we support it in any of the higher layers. From reading the release notes though, some of the bug fixes seem interesting e.g. the list parsing ones. Bug 204740 should be fixed by http://issues.apache.org/jira/browse/NET-215 for instance. Kat, out of curiosity... where would you want to use a commons.net bundle that comes from Orbit?
(In reply to comment #1) > Whow, that was fast ... commons net must have just been released! > > For TM/RSE I'm afraid IPv6 support is not relevant since I don't think we > support it in any of the higher layers. From reading the release notes though, > some of the bug fixes seem interesting e.g. the list parsing ones. Bug 204740 > should be fixed by http://issues.apache.org/jira/browse/NET-215 for instance. > > Kat, out of curiosity... where would you want to use a commons.net bundle that > comes from Orbit? We currently use it, via RSE, in an RCP we build. So I'd like to get it updated so that we can support IPv6.
Before we proceed adding commons net 2.2.0 to Orbit, I would like us to do some testing with the new version. Apache downloads seem to be down at the moment, but here's what I'd suggest: 1. Download the binary JAR from Apache 2. Rename to follow OSGi naming, and inject an OSGi MANIFEST.MF - Should be easy to create by comparing with the current 2.0 MANIFEST.MF 3. Attach here on bugzilla for testing Downloading the bundle and placing it into dropins/ should pick up the new version immediately, so we can test it. When we are happy with the results, we can initiate the IP Due Diligence process and formally add it to Orbit. Kat, since you seem to be the one most interested, could you get the binary, prepare it, perform initial testing and attach here on Bugzilla?
Adding other commons.net interested parties according to IPZilla: technogoly.osee, technology.linux-distros, soa.ebpm, rt.ecf, tools.sequoyah
Created attachment 183911 [details] org.apache.commons.net_2.2.0.v01.jar for testing Attached "org.apache.commons-net_2.2.0.v01.jar" can be used for testing. It seems to work fine for me on Eclipse 3.7m3 / TM 3.2.1, as well as Eclipse 4.1m3 / TM 3.3 LATEST. It's the original binary, with following modifications for Orbit: - Add about.html - Move META-INF/NOTICE.TXT to about_files/ - Move META-INF/LICENSE.TXT to about_files/ - MANIFEST.MF : Add Bundle-RequiredExecutionEnvironment: J2SE-1.5 - MANIFEST.MF : Change Bundle-Version to 2.2.0.v01 - MANIFEST.MF : Add Bundle-Localization: plugin - Add plugin.properties (for localization of vendor, name, description) - Change Bundle-Name: Commons Net -> "Apache Commons Net" - Change Bundle-Vendor: Apache -> "Eclipse Orbit" One question at this point is whether I should better keep an additional copy of NOTICE.TXT and LICENSE.TXT inside META-INF/ for compatibility with other consumers. I'll wait about 2 weeks for testing / comments before I initiate the CQ process.
Created attachment 183913 [details] org.apache.commons.net.source_2.2.0.v01.jar for testing source bundle for debugging into commons.net_2.2 while testing.
(In reply to comment #6) > Created an attachment (id=183913) [details] > org.apache.commons.net.source_2.2.0.v01.jar for testing > > source bundle for debugging into commons.net_2.2 while testing. Sorry, been ill for a few days - I'm more than happy to test and post back here. I'll get it down in the next couple of days.
(In reply to comment #3) Please remember to test whether commons net 2.2.0 addresses your needs, and provide feedback. The deadline for bringing in new IP into the yearly Eclipse train is typically end of January. In case we find a defect in commons net 2.2.0 we'll have to have that defect addressed and released as 2.2.1 by that time - so we better test early. Test instructions are simple: Just download attached two JAR's and place them into the dropins/ folder of your Eclipse install.
Has anybody verified that commons net 2.2 is good to use, and particularly satisifies the needs for IPv6 ?
Ping? I'm not going to add this to Eclipse without confirmation that it actually solves the original issue.
(In reply to comment #10) > Ping? > > I'm not going to add this to Eclipse without confirmation that it actually > solves the original issue. +1 from Linux Tools and Fedora land We should always strive to use the latest released library...
Ok, since Fedora and Linuxtools are the first to really want this, can you file the initial CQ for IP review? After that, we'd piggyback Orbit on that, and after that I'd piggyback TM on Orbit. I think you could use the source jar attached here for the Review, since I already stripped the testing sources and other stuff we won't distribute.
I also suggest changing the Summary of this bug to read "add commons net 2.2.0 to Orbit" since it looks like you want it just for the version uprev (not implying any particular new functionality that you want).
Created CQs... https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4742 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4743 Once it's approved... I'll put it in Orbit.
Thanks Chris. Once approved, I can also do the Orbit commit since I've already created the files.
(In reply to comment #15) > Thanks Chris. > Once approved, I can also do the Orbit commit since I've already created the > files. Wooo, go for it Martin! It's approved now :) https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4743
Will commit when the dust settles a bit over the recent Orbit Gogo addition :)
(In reply to comment #17) > Will commit when the dust settles a bit over the recent Orbit Gogo addition :) Heh, I've been adding libraries anyway :)
Created attachment 187399 [details] Patch adding 2.2 to Orbit Builder
Added to Orbit, builds >= 20110124-0552
