Bug 330592 - Exclude unlisted EclipseLink XML mapping file checkbox needs clearer label
Summary: Exclude unlisted EclipseLink XML mapping file checkbox needs clearer label
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Neil Hauge CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2010-11-18 12:30 EST by Nan Li CLA
Modified: 2013-02-12 13:50 EST (History)
5 users (show)

See Also:
rick.sapir: documentation+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Li CLA 2010-11-18 12:30:21 EST 
Build Identifier: 20100917-0705

Setting the value of the persistence unit property 'eclipselink.exclude-eclipselink-orm' to false or setting the checkbox of 'Exclude unlisted EclipseLink XML mapping file' to default or unchecked status doesn't lead the persistence unit to include the created EclipseLink mapping files. This works for the EclipseLink mapping file with the default name 'eclipselink-orm.xml' though.

Reproducible: Always

Steps to Reproduce:
1. Create a JPA project
2. Open persistence.xml and go to 'XML Mapping Files' on the General tab to make sure the value of 'Exclude unlisted EclipseLink XML mapping file' is false
3. Right-click the META-INF folder and select New -> EclipseLink Mapping File
4. Give the mapping file a name that is different from the default one
5. Go back to the opened persistence.xml and then go to the JPA Structure view to check if the created EclipseLink mapping file is included.
Comment 1 Karen Butzke CLA 2010-11-19 12:25:16 EST 
I believe the functionality is correct here, but the wording of the check box label could be made more clear. The property is only supposed to apply to the special default eclipselink-orm.xml with that name. From the EclipseLink API:


/**
 * The <code>"eclipselink.exclude-eclipselink-orm"</code> property
 * configures the exclusion of an EclipseLink ORM mapping file for a
 * specific persistence unit. By default the first file found at the
 * resource name: "META-INF/eclipselink-orm.xml" is processed and overrides
 * configurations specified in annotations, and standard mapping files.
 */
public static final String EXCLUDE_ECLIPSELINK_ORM_FILE = "eclipselink.exclude-eclipselink-orm";


We also need to fix the docs, they are confusing as well: http://help.eclipse.org/galileo/index.jsp?topic=/org.eclipse.jpt.doc.user/task_manage_persistence.htm
Comment 2 Neil Hauge CLA 2011-07-01 16:23:11 EDT 
Moving JPA specific bugs to new JPA component in bugzilla.
Comment 3 Neil Hauge CLA 2011-10-07 12:51:45 EDT 
Targeting to Juno release.
Comment 4 Neil Hauge CLA 2012-09-24 12:10:22 EDT 
How about we change "unlisted" to "default"?  "Default" seems to better represent what this property is configuring.  

Rick,

Copying you on this so you can update the user docs as necessary.
Comment 5 Rick Sapir CLA 2012-09-25 07:26:37 EDT 
Updated docs/help to reflect new field name.
Comment 6 Neil Hauge CLA 2012-09-26 18:22:07 EDT 
Fixed in M2.
Comment 7 Jolene Moffitt CLA 2013-02-12 13:50:10 EST 
Verified in build S-3.5.0M5-20130206143825 that the build contains a newer version of the help with the updates.  To view steps to verify this issue go to http://wiki.eclipse.org/Dali_3.3_M2_Release