Bug 32981 - Cancel Extract Interface refactoring does not cleanup working copies
Summary: Cancel Extract Interface refactoring does not cleanup working copies
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 critical (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-25 10:37 EST by Dani Megert CLA
Modified: 2003-03-10 07:09 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2003-02-25 10:37:18 EST
Build 2.1 RC1

0. Open Java Browsing perspective
1. Select a type in the Types view
2. Refactor -> Extract Interface...
3. Press "Preview"
Observe: the type appears in the Types view
4. Press "Cancel"
==> The type remains in the Types view

I verified that the content provider does not get a Java element delta upon cancel.
Comment 1 Dirk Baeumer CLA 2003-02-26 12:39:49 EST
Adam, we have to check other refactorings as well which create working copies.
Comment 2 Adam Kiezun CLA 2003-03-03 10:01:14 EST
extract interface correctly destroys the worksing copy
moving to jcore because it looks like no delta is sent on destroy()
Comment 3 Jerome Lanneluc CLA 2003-03-04 05:27:02 EST
IWorkingCopy.getWorkingCopy() and IWorkingCopy.destroy() now correctly send a 
delta indicating the addition/removal of the working copy.

Added regression test JavaElementDeltaTests.testCreateWorkingCopy() and 
testDestroyWorkingCopy()
Comment 4 David Audel CLA 2003-03-10 07:09:47 EST
Verified.