Bug 329584 - [1.4/1.5][compiler] Compiler is confused about name clashes in 1.4 project
Summary: [1.4/1.5][compiler] Compiler is confused about name clashes in 1.4 project
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Srikanth Sankaran CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-05 15:56 EDT by Thomas Watson CLA
Modified: 2010-12-07 12:13 EST (History)
1 user (show)

See Also:
Olivier_Thomann: review+

Attachments
test.hooks project (5.54 KB, application/octet-stream)
2010-11-05 15:56 EDT, Thomas Watson CLA 		no flags Details
Proposed fix + test (2.25 KB, patch)
2010-11-06 08:22 EDT, Srikanth Sankaran CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2010-11-05 15:56:35 EDT 
Created attachment 182524 [details]
test.hooks project

I am running with the latest jdt.core in HEAD.  The attached project gives me unexpected name clashes and also results in errors about unimplemented method.
Comment 1 Olivier Thomann CLA 2010-11-05 16:28:44 EDT 
I added a regression test in:
org.eclipse.jdt.core.tests.compiler.regression.MethodVerifyTest._test329584()
Comment 2 Srikanth Sankaran CLA 2010-11-06 02:46:12 EDT 
Same type equivalence issue as discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=328827#c3  and
https://bugs.eclipse.org/bugs/show_bug.cgi?id=329593#c2

This time the method to
fix is org.eclipse.jdt.internal.compiler.lookup.MethodVerifier15.areTypesEqual(TypeBinding, TypeBinding)
Comment 3 Srikanth Sankaran CLA 2010-11-06 08:22:17 EDT 
Created attachment 182552 [details]
Proposed fix + test

Thanks for the regression test, Olivier.
I have enabled the test with this fix.
Comment 4 Srikanth Sankaran CLA 2010-11-06 08:26:45 EDT 
Released in HEAD for 3.7 M4.

Olivier, To preserve my sanity, I have released the fix
ahead of review. 

Please go ahead and review the fix. TIA.
Comment 5 Olivier Thomann CLA 2010-11-12 08:52:37 EST 
Looks good.
Comment 6 Olivier Thomann CLA 2010-12-07 12:13:29 EST 
Verified using I20101207-0250 (4.1 I-build)