Community
Participate
Working Groups
For instance, consider org.apache.commons.el : http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.orbit/org.apache.commons.el/about.html?view=markup&revision=1.1.2.3&root=Tools_Project&pathrev=v1_0 The paragraph "<p>Your use of the Commons EL code is subject to..." is not terminated with a </p> tag, although the document has an XHTML-strict doctype header. This is problematic for tooling to work on about's (Wayne?), but also makes the Help webapp fail with a SAX error message: http://help.eclipse.org/helios/index.jsp?topic=/org.apache.commons.el/about.html whereas this works fine for proper XHTML: http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.ui.ide/about.html I'm not sure how to discover all instances of invalid XHTML, perhaps the gurus from WST could come up with some tooling, maybe integrated with the build, to fix this for Indigo? - A couple other broken XHTML about's that I detected include: http://help.eclipse.org/helios/index.jsp?topic=/com.ibm.icu/about.html http://help.eclipse.org/helios/index.jsp?topic=/org.sat4j.core/about.html http://help.eclipse.org/helios/index.jsp?topic=/org.apache.commons.httpclient/about.html http://help.eclipse.org/helios/index.jsp?topic=/org.apache.commons.codec/about.html http://help.eclipse.org/helios/index.jsp?topic=/org.apache.commons.logging/about.html to me it looks like the defect got introduced early and then replicated via copy & paste. BTW, I also suspect that some copyright notices / copyright years did not get updated properly when reving up a bundle version or cloning an existing bundle to get a new one in...
I fixed the issue for org.apache.commons.httpclient org.apache.commons.net org.apache.log4j
Created attachment 184737 [details] patch v1 I have taken a first pass at fixing the XHTML in those bundle's about that we're shipping in our product: com.jcraft.jsch javax.servlet.jsp org.apache.commons.codec org.apache.commons.el org.apache.commons.logging org.apache.jasper org.apache.lucene org.apache.lucene.analysis org.apache.xerces org.sat4j.core org.sat4j.pb Turned out that each bundle had slightly different problems, so it was a manual approach (using WTP's "validate"). When I release those changes, respective bundles will be updated in Indigo. Before I proceed though, I just wanted to check back with the group whether that's really what we want - since the defect itself isn't a major thing.
Created attachment 187300 [details] bundles.map changes Since I did not hear any concerns, I finally committed these changes. Turned out that for some bundles, newer versions are around now: javax.servlet.jsp -- I fixed 2.0.0 but did not check 2.1.0 org.apache.commons.logging -- I fixed 1.0.4 but did not check 1.1.1 org.apache.lucene/analysis -- I fixed 1.9.2 but did not check 2.9.2 com.jcraft.jsch -- I fixed 0.1.41 but did not check 0.1.44 I also noticed that for plugin@org.apache.jasper,5.5.17 the branch tag (,5.5.17) had been missing in bundles.map. This is now fixed. I would appreciate if bundle maintainers could check their about.html files for proper xhtml syntax from now on. Just apply a Webtools validate before checkin.
Created attachment 187303 [details] Additional patch for newer versions
So I fixed the newer versions too: > javax.servlet.jsp 2.1.0 > org.apache.commons.logging 1.1.1 > org.apache.lucene/analysis/core 2.9.1 > com.jcraft.jsch 0.1.44 This should fix all the about XHTML for Orbit bundlis shipped with the core Platform Runtime. I'm going to leave the bug open though since I cannot check all the bundles in the repo. Again, ideally each bundle maintainer should derive new about.html files from kosher ones, and run WTP validate on them.
(In reply to comment #5) > So I fixed the newer versions too: > > > javax.servlet.jsp 2.1.0 > > org.apache.commons.logging 1.1.1 > > org.apache.lucene/analysis/core 2.9.1 > > com.jcraft.jsch 0.1.44 > > This should fix all the about XHTML for Orbit bundlis shipped with the core > Platform Runtime. I'm going to leave the bug open though since I cannot > check all the bundles in the repo. > > Again, ideally each bundle maintainer should derive new about.html files > from kosher ones, and run WTP validate on them. Perhaps you could udpate wiki at http://wiki.eclipse.org/Orbit/Adding_Bundles_to_Orbit and then count this as "fixed"?
