Bug 329323 - Parser(and the indexing also) is workspace-dependent
Summary: Parser(and the indexing also) is workspace-dependent
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-parser (show other bugs)
Version: 8.0   Edit
Hardware: All other
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-03 04:35 EDT by ben (Istvan Benedek) CLA
Modified: 2020-09-04 15:18 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ben (Istvan Benedek) CLA 2010-11-03 04:35:23 EDT
Build Identifier: I20101028-1441

Reason: all IncludeFileContentProvider implementations have workspace dependency.

There is no workspace-independent instance for include-file reading: the getSavedFilesProvider() method provides a class (SavedFilesProvider), that handles both.
It checks the Workspace first and use external files afterwards.
Even if such mixed include-processing is required (system headers?), a workspace-free (only external) implementation should also be present (for standalone parsing).
I suggest a new IncludeFileContentProvider.getExternFilesProvider() method with a proper implementation.

Please drop me a notice if i should you provide a patch for this:
 the splitting of the mentioned SavedFilesProvider is pretty straight forward; the resulting extern-reader can be even used as base for it.

Reproducible: Always

Steps to Reproduce:
check the SavedFilesProvider.getContentForInclusion() for dependencies.
Comment 1 Markus Schorn CLA 2010-11-04 06:19:01 EDT
(In reply to comment #0)
> ...
> I suggest a new IncludeFileContentProvider.getExternFilesProvider() method 
> with a proper implementation.
> Please drop me a notice if i should you provide a patch for this:
>  the splitting of the mentioned SavedFilesProvider is pretty straight forward;
> the resulting extern-reader can be even used as base for it.
A patch would be nice, I don't see the need for basing SavedFilesProvider on the new FileContentProvider.