Bug 329268 - DOM AST support for Type Patterns
Summary: DOM AST support for Type Patterns
Status: NEW
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 11:48 EDT by Nieraj Singh CLA
Modified: 2010-11-14 18:22 EST (History)
0 users

See Also:


Attachments
Initial implementation of feature (72.26 KB, patch)
2010-11-03 13:08 EDT, Nieraj Singh CLA
no flags Details | Diff
Feature patch with additional test cases and polished code (120.01 KB, patch)
2010-11-14 18:22 EST, Nieraj Singh CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nieraj Singh CLA 2010-11-02 11:48:04 EDT
Build Identifier: 

Enhance the DOM AST to support type pattern nodes, including:

AndTypePattern
OrTypePattern
AnyTypePattern
TypePatternMaybe
AnyWithAnnotationTypePattern
EllipsisTypePattern
HasMemberTypePattern
NotTypePattern
NoTypePattern
TypeCategoryTypePattern
ExactTypePattern
BindingTypePattern
WildTypePattern

Test cases should be added that build the nodes both before and after types are resolved, and both cases should be handled in the AjASTConverter

See equivalent AST weaver nodes for further details on each node type.

The initial implementation of the nodes should hold the source range and type information obtained from the weaver nodes.




Reproducible: Always
Comment 1 Nieraj Singh CLA 2010-11-03 13:08:19 EDT
Created attachment 182310 [details]
Initial implementation of feature

This initial implementation contains new DOM nodes for TypePatterns. However, it has only been tested in a unresolved scenario, therefore the only nodes that are created are WildTypePattern, And, and OR type patterns. Other type patterns need to be tested.
Comment 2 Nieraj Singh CLA 2010-11-14 18:22:33 EST
Created attachment 183097 [details]
Feature patch with additional test cases and polished code

Contains the TypePattern feature for declare parents, with additional test cases and polished code.