Bug 328374 - [nls tooling] Properties file editor should report errors for incorrect characters
Summary: [nls tooling] Properties file editor should report errors for incorrect chara...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-21 11:28 EDT by Deepak Azad CLA
Modified: 2012-08-08 15:52 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2010-10-21 11:28:01 EDT 
The properties file editor should show 
- an error marker if the there is a malformed \uxxxx sequence. Currently this
just fails at runtime.
- a warning is there is an unnecessary \. Currently this is just silently
ignored.
Comment 1 Dani Megert CLA 2010-10-21 11:36:10 EDT 
This would need a builder. Questionable whether we want to waste performance for such a feature.

What we could do easily is reporting this as part of our "Find Broken Externalized Strings" action.
Comment 2 Deepak Azad CLA 2010-10-21 11:45:39 EDT 
(In reply to comment #1)
> What we could do easily is reporting this as part of our "Find Broken
> Externalized Strings" action.
How about showing the problems the same way as Spell errors in an open editor? The computation could probably be done along with coloring of special characters (Bug 106721).
Comment 3 Dani Megert CLA 2010-10-21 11:48:08 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> > What we could do easily is reporting this as part of our "Find Broken
> > Externalized Strings" action.
> How about showing the problems the same way as Spell errors in an open editor?
> The computation could probably be done along with coloring of special
> characters (Bug 106721).

Yep, good idea!