Bug 32738 - TVT: Externalized Strings to be removed from .properties file
Summary: TVT: Externalized Strings to be removed from .properties file
Status: RESOLVED WORKSFORME
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 critical (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-24 13:20 EST by Hwa Truong CLA
Modified: 2003-02-27 06:02 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hwa Truong CLA 2003-02-24 13:20:29 EST
Steps:
1. open java perspective
2. create a new class
3. add a new field int i to the class
4. right click on the new added field i, select source->generate getter and
setter
5. click ok on generate getter and setter window
6. check the code to see what is generated.
If you conpare the result from zh_TW locale to other locales,
you will notice that for other locales, what is generated is: getI
(); and setI(int i);
But in zh_TW locale, the getI() becames "Chinese get CHAR"I(); and the
setI(int i) changed into
"Chinese set CHAR"I(int i);

Due to fact that some internal labels are translated, the getI and setI are 
changed into particular characters.  
This bug was first introduced as PMR43977. The following file has key lines 
that should not be translated.  There should be a comment or something to mark 
that the following lines are not to be translated.

In the file codegenerationmessages.properties at 
eclipse\plugins\org.eclipse.jdt.ui_2.0.2
\jdt_jar\org\eclipse\jdt\internal\corext\codemanipulation

NameProposer.getterPrefix=get
NameProposer.queryPrefix=is
NameProposer.setterPrefix=set
Comment 1 Cam-Thu Le CLA 2003-02-24 14:12:08 EST
This problem was logged against translation of 2.0.2. However, after analysing
the problem, we realized that strings which should not be externalized for
translation had been put into file codegenerationmessages.properties of
directory eclipse\plugins\org.eclipse.jdt.ui_2.0.2
\jdt_jar\org\eclipse\jdt\internal\corext\codemanipulation
Please ensure that the 3 keywords are being removed from the .properties file
for eclipse 2.1 so that the translation centers will not make a mistake of
translating them.  
NameProposer.getterPrefix=get
NameProposer.queryPrefix=is
NameProposer.setterPrefix=set
Comment 2 Dirk Baeumer CLA 2003-02-26 06:44:47 EST
If we remove this from the properties file JDT/UI will always suggest setter and 
getters of the form: setValue, getValue. If the field identifier is not written in English 
but in German you will get setWert and getWert which is funny as well. 
Comment 3 Dirk Baeumer CLA 2003-02-26 10:33:52 EST
The NamePropser class is no longer in use in JDT/UI. Removed keys form JDT/UI 
land. 

Moving to JDT/Core since they are now doing name proposing. 
Comment 4 Philipe Mulet CLA 2003-02-26 10:40:58 EST
David - pls verify that these strings are indeed externalized.
Comment 5 Philipe Mulet CLA 2003-02-27 05:47:01 EST
Actually, these Strings should NOT be externalized as per original request.
Comment 6 David Audel CLA 2003-02-27 06:02:55 EST
Currently these Strings are not externalized.

Closing.