Bug 326911 - Layout test could also check manifest.mf entries
Summary: Layout test could also check manifest.mf entries
Status: NEW
Alias: None
Product: Orbit
Classification: Tools
Component: releng (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 08:38 EDT by David Williams CLA
Modified: 2011-05-18 13:30 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-10-04 08:38:40 EDT 
+++ This bug was initially created as a clone of Bug #295949 +++

Our layout tests simply look for the absence of certain files in the bundle as it is laid out ... as a quick and simple sanity check. As was suggested in the original bug of this clone, a common error that is not caught is that the manifest.mf file does not have the proper header, to "match" the file layout ... such as for the method of localization (e.g. a bundle might have "plugin.properties", this passing the layout test, but does not have a Bundle-Localization header to localization would not work at runtime). 

So, ideally, some "manifest tests" could also be added as unit tests.
Comment 1 David Williams CLA 2011-05-18 13:30:30 EDT 
Note, if/when we improve these tests again, we should allow for "fragment.properties", as I learned in bug 344003. 

Don't think we currently have any fragments in Orbit, but as far as I know, it wouldn't be impossible.