Community
Participate
Working Groups
code from HEAD It has been found that we are lacking the ability to signal that a resume has occurred from a client (remote or local), meaning the only way to update the corresponding UI is to actually make a call to JavaScriptThread.resume() or perform a step operation. These are no viable options because: 1. if a remote client sends a resume event and we invoke JavaScriptThread.resume() it delegates to the underlying ThreadReference which in turn could issue a command to the client - bad for stability and performance 2. if we have to issue some form of step command, we could alter the debugger / client state just to cause a resume - bad for stability and sanity To fix this would require three API changes one of them breaking. 1. we would have to add ResumeEvent to o.e.w.j.d.c.jsdi.event, which clients would be free to implement or not as they see fit 2. we would have to add ResumeEventRequest to o.e.w.j.d.c.jsdi.request, which clients would need to implement due to the API for: 3. the breaking change - we would have to add createResumeRequest() and resumeRequests() to EventRequestManager so the new event can be requested The other option to mitigate the breaking API change would be create an EventRequestManager2 that extends EventRequestManager, but I would prefer to not do this.
Created attachment 181438 [details] fix The patch provides the fix as a breaking API change, it also contains the update to our Rhino implementation to create / manage the new event / request
Applied patch to HEAD, rev'd debug.core's version to 2.0 to denote the breaking API change