Bug 32634 - Improve readability of compiling progress message
Summary: Improve readability of compiling progress message
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Kent Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-24 07:34 EST by Philipe Mulet CLA
Modified: 2003-03-11 06:16 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-02-24 07:34:08 EST
Build RC1

From EG:
It is great to see the accumulated errors, but it uses too many of my brain 
cycles to
interpret the numbers. What I want to see at a glance is whether there are 
newly found errors.
Now this information is spread apart:

Found/Fixed  Errors 3/0    Warinng 3/1

Can we group this differently:
Found 3 Errors (0 warnings),  Fixed 3 (0)
Comment 1 Philipe Mulet CLA 2003-02-24 07:34:45 EST
I had the exact same comment to Kent. He wanted to make them compact, and I 
also have a hard decoding this info too.
We will improve as we get feedback...
Comment 2 Philipe Mulet CLA 2003-02-24 07:35:09 EST
From Kent:

Some things to keep in mind:

1. Some people do not care about warnings at all and would prefer not to see 
them.

2. We have very limited space since the overall builder message cannot be split 
over 2 lines. This portion will come before the rest of the progress message.

3. The compound message is not displayed that often since you usually are 
adding problems or fixing problems, not both.

So the various messages will be:

Found: 3 errors
Found: 2 warnings
Found: 3 errors, 2 warnings

Fixed: 2 errors
Fixed: 4 warnings
Fixed: 2 errors, 4 warnings

And then:

Found/Fixed: 3/2 errors, 2/4 warnings
OR
Found: 3 errors (2 warnings), Fixed: 2 (4)
OR
Found: 3 errors, Fixed: 2 errors - and drop the warnings all together
Comment 3 Philipe Mulet CLA 2003-02-24 07:35:22 EST
I personally care about errors vs warnings.

The current message usually spans over 2 lines (wrapping just 
after 'compiling'), which means that even if we don't produce a 2 line message, 
we still have room to make it more human readable.

This one reads ok to me:

Found: 3 errors (2 warnings), Fixed: 2 (4)
Comment 4 Philipe Mulet CLA 2003-02-24 07:35:40 EST
From Erich:

One more nit.

Since users have to be able to scan these messages quickly both the found
and fixed messages formats should be constant and not
change dynamcially. Instead of:
Found: 3 errors
Found: 2 warnings
Found: 3 errors, 2 warnings

there should be a fixed message:
Found: 3 errors (0 warnings)
Found: 0 errors (2 warnings)
Found: 3 errors (2 warnings).
Comment 5 Kent Johnson CLA 2003-02-24 10:25:59 EST
Too many of the progress dialogs do not wrap the text since they are restricted 
to a single line. Take a look at the progress line in the left corner of the 
Java perspective, there is only room for about 40 characters total.

Unless we're saying that we don't care about the builder message 
(Compiling ..., or Cleaning output folder...), then we have to limit the size 
of this message. Even more so now since it will be visible throughout the build.

Showing (0 warnings) in 'Found: 3 errors (0 warnings), Fixed: 1 (0)' will clip 
the builder messages off considerably.
Comment 6 Kent Johnson CLA 2003-02-27 11:44:23 EST
In the latest drop the compound message was changed to:

Found 3 errors + 2 warnings, Fixed 2 + 4

Will wait for feedback before closing this PR.
Comment 7 Philipe Mulet CLA 2003-03-05 06:04:21 EST
Would this read bad:    (+3 errors, -12 warnings) ?
Comment 8 Erich Gamma CLA 2003-03-05 06:22:10 EST
what message would show up when 2 warnings were found and 2 warnings were fixed?
Comment 9 Philipe Mulet CLA 2003-03-05 06:33:30 EST
Ok, I stop arguing <g>
Comment 10 Kent Johnson CLA 2003-03-06 10:42:12 EST
Done. Closing since the RC2 builds start today.
Comment 11 David Audel CLA 2003-03-11 06:16:21 EST
Verified.