Bug 32628 - Too much time finding out there is no source during search
Summary: Too much time finding out there is no source during search
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-24 07:16 EST by Jerome Lanneluc CLA
Modified: 2003-03-10 11:59 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2003-02-24 07:16:06 EST 
Build 20030221

Java search is using the SourceMapper to find out if a class file as a 
corresponding source. However in the case a source zip is attached to a jar 
file, but the source zip is incomplete (case or src.zip for rt.jar), potential 
matches in class files don't have a corresponding source. In this case too much 
time is spent in the SourceMapper trying to compute a root path for these class 
files.
Comment 1 Olivier Thomann CLA 2003-02-24 09:16:56 EST 
The solution consists in computing all root paths when the first type is
requested. Then there is no further computation in case the source doesn't exist.
Comment 2 Olivier Thomann CLA 2003-02-25 14:16:45 EST 
Fixed and released in 2.1 stream.
Comment 3 Olivier Thomann CLA 2003-03-10 11:59:15 EST 
Verified in source code. There is only one computation of root paths. I checked 
that this is correct in the tests.