Bug 3256 - SearchableEnvironment - converts char[] to String, which affects performance (1GDGIUP)
Summary: SearchableEnvironment - converts char[] to String, which affects performance ...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: 2.0 M4   Edit
Assignee: Kent Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:52 EDT by Olivier Thomann CLA
Modified: 2002-03-11 17:02 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2001-10-10 22:52:06 EDT 
AK (5/9/01 1:44:51 PM)
	SearchableEnvironment::findType(char[], char[][])
	creates new String objects. the result is that, furher down the line, NameLookup.nameMatches 
	spends lots of time converting to lowercase (String.toLowercase), which acctually creates more String objects

NOTES:

AK (5/9/01 8:15:54 PM)
	note that String constructor together with toLowerCase account for more than 35% of search time 
	(that's what 'OptimizeIt' says).
	i'm not sure but maybe some of this could be avoided by not creating the strings and just using the char[]

PM (6/19/2001 3:55:22 PM)
	toLowercase/toUppercase invocations should be fixed  by now.
	However need to investigate some more the environment implementation.
Comment 1 DJ Houghton CLA 2001-10-23 23:53:10 EDT 
PRODUCT VERSION:
	104a
Comment 2 Olivier Thomann CLA 2002-03-01 15:11:12 EST 
Fixed.
Comment 3 Olivier Thomann CLA 2002-03-01 15:11:32 EST 
Wrong pr.
Comment 4 Philipe Mulet CLA 2002-03-07 07:02:22 EST 
This one is along the path of name environment char to String performance tweak 
you are investigating for the builder environment.

Can you please look at this one too ?
Comment 5 Kent Johnson CLA 2002-03-11 17:02:48 EST 
Made a few minor changes. Looks fine.